Conversation
|
| Filename | Overview |
|---|---|
| package.json | TypeScript bumped from 5.9.3 to 6.0.2 (major version) and @typescript-eslint packages patched to 8.57.2; however, all @typescript-eslint 8.57.x packages declare typescript: '>=4.8.4 <6.0.0' as a peer dependency, so TS 6.0.2 is out-of-range and the linting toolchain may break. |
| pnpm-lock.yaml | Lock file updated to reflect typescript@6.0.2 across all peer-dependency slots; resolution metadata for @typescript-eslint/* packages clearly shows typescript: '>=4.8.4 <6.0.0' constraints, confirming the peer-dep violation introduced by the TypeScript major-version bump. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
TS["typescript@6.0.2\n(this PR)"]
TSE_PLUGIN["@typescript-eslint/eslint-plugin@8.57.2\npeerDep: typescript >=4.8.4 <6.0.0"]
TSE_PARSER["@typescript-eslint/parser@8.57.2\npeerDep: typescript >=4.8.4 <6.0.0"]
TSE_ESTREE["@typescript-eslint/typescript-estree@8.57.2\npeerDep: typescript >=4.8.4 <6.0.0"]
TSE_META["typescript-eslint@7.18.0\n(meta-package, ^7.7.1)"]
TSUTILS["tsutils@3.21.0\n(legacy)"]
LINT["pnpm lint\n(ESLint + type-aware rules)"]
BUILD["pnpm build / typecheck\n(tsc / tsup)"]
TS -->|"✅ major version, likely compatible"| BUILD
TS -->|"❌ violates <6.0.0 constraint"| TSE_PLUGIN
TS -->|"❌ violates <6.0.0 constraint"| TSE_PARSER
TS -->|"❌ violates <6.0.0 constraint"| TSE_ESTREE
TS -->|"⚠️ likely constraint violation"| TSE_META
TS -->|"⚠️ old package, unsupported"| TSUTILS
TSE_PLUGIN --> LINT
TSE_PARSER --> LINT
TSE_ESTREE --> LINT
TSE_META --> LINT
Prompt To Fix All With AI
This is a comment left during a code review.
Path: package.json
Line: 69-70
Comment:
**TypeScript 6.x violates `@typescript-eslint` peer dependency constraints**
The `@typescript-eslint/eslint-plugin@8.57.2`, `@typescript-eslint/parser@8.57.2`, and related packages (`@typescript-eslint/project-service`, `@typescript-eslint/tsconfig-utils`, `@typescript-eslint/typescript-estree`, `@typescript-eslint/type-utils`) all declare a peer dependency of `typescript: '>=4.8.4 <6.0.0'` (visible in `pnpm-lock.yaml`). TypeScript 6.0.2 is outside this supported range.
Similarly, `typescript-eslint@^7.7.1` (resolved to `7.18.0`) and `tsutils@^3.21.0` also have similar constraints.
This peer dependency mismatch means:
- pnpm will emit unsatisfied peer dependency warnings at install time
- ESLint's type-aware linting rules may produce incorrect results or fail outright, since the `@typescript-eslint` AST parser is not guaranteed to work with TypeScript 6.x's compiler API
- The `typecheck` and `lint` CI steps are at risk of producing false negatives
To resolve this, the `@typescript-eslint` packages should be upgraded to a version that explicitly supports TypeScript 6.x (likely `@typescript-eslint/*` v8.58+ or the `typescript-eslint` v8 meta-package), or TypeScript should remain at the latest 5.x release until the linting toolchain catches up.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "Update dependencies" | Re-trigger Greptile
| "typescript": "6.0.2", | ||
| "typescript-eslint": "^7.7.1" |
There was a problem hiding this comment.
TypeScript 6.x violates
@typescript-eslint peer dependency constraints
The @typescript-eslint/eslint-plugin@8.57.2, @typescript-eslint/parser@8.57.2, and related packages (@typescript-eslint/project-service, @typescript-eslint/tsconfig-utils, @typescript-eslint/typescript-estree, @typescript-eslint/type-utils) all declare a peer dependency of typescript: '>=4.8.4 <6.0.0' (visible in pnpm-lock.yaml). TypeScript 6.0.2 is outside this supported range.
Similarly, typescript-eslint@^7.7.1 (resolved to 7.18.0) and tsutils@^3.21.0 also have similar constraints.
This peer dependency mismatch means:
- pnpm will emit unsatisfied peer dependency warnings at install time
- ESLint's type-aware linting rules may produce incorrect results or fail outright, since the
@typescript-eslintAST parser is not guaranteed to work with TypeScript 6.x's compiler API - The
typecheckandlintCI steps are at risk of producing false negatives
To resolve this, the @typescript-eslint packages should be upgraded to a version that explicitly supports TypeScript 6.x (likely @typescript-eslint/* v8.58+ or the typescript-eslint v8 meta-package), or TypeScript should remain at the latest 5.x release until the linting toolchain catches up.
Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 69-70
Comment:
**TypeScript 6.x violates `@typescript-eslint` peer dependency constraints**
The `@typescript-eslint/eslint-plugin@8.57.2`, `@typescript-eslint/parser@8.57.2`, and related packages (`@typescript-eslint/project-service`, `@typescript-eslint/tsconfig-utils`, `@typescript-eslint/typescript-estree`, `@typescript-eslint/type-utils`) all declare a peer dependency of `typescript: '>=4.8.4 <6.0.0'` (visible in `pnpm-lock.yaml`). TypeScript 6.0.2 is outside this supported range.
Similarly, `typescript-eslint@^7.7.1` (resolved to `7.18.0`) and `tsutils@^3.21.0` also have similar constraints.
This peer dependency mismatch means:
- pnpm will emit unsatisfied peer dependency warnings at install time
- ESLint's type-aware linting rules may produce incorrect results or fail outright, since the `@typescript-eslint` AST parser is not guaranteed to work with TypeScript 6.x's compiler API
- The `typecheck` and `lint` CI steps are at risk of producing false negatives
To resolve this, the `@typescript-eslint` packages should be upgraded to a version that explicitly supports TypeScript 6.x (likely `@typescript-eslint/*` v8.58+ or the `typescript-eslint` v8 meta-package), or TypeScript should remain at the latest 5.x release until the linting toolchain catches up.
How can I resolve this? If you propose a fix, please make it concise.
Dependency updates
Auto-generated by [codependence][1] using [create-pull-request][2]
[1]: https://github.com/yowainwright/build-lambda-layer
[2]: https://github.com/peter-evans/create-pull-request