Skip to content

Commit 1d65a86

Browse files
committed
Ask to use CalciteCrossClusterSearchIT when developing calcite-only commands
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
1 parent 2fd3186 commit 1d65a86

2 files changed

Lines changed: 1 addition & 4 deletions

File tree

docs/dev/ppl-commands.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ If you are working on contributing a new PPL command, please read this guide and
5252
- Add a test in `PPLQueryDataAnonymizerTest`
5353

5454
- [ ] **Cross-cluster Tests (optional, nice to have):**
55-
- Add a test in `CrossClusterSearchIT`
55+
- Add a test in `CrossClusterSearchIT`, or in `CalciteCrossClusterSearchIT` if the command requires Calcite.
5656

5757
- [ ] **User doc:**
5858
- Add a xxx.md under `docs/user/ppl/cmd` and link the new doc to `docs/user/ppl/index.md`

integ-test/src/test/java/org/opensearch/sql/security/CalciteCrossClusterSearchIT.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,6 @@ public void testCrossClusterRexWithOffsetField() throws IOException {
352352

353353
@Test
354354
public void testCrossClusterAddTotals() throws IOException {
355-
// Test query_string without fields parameter on remote cluster
356355
JSONObject result =
357356
executeQuery(
358357
String.format(
@@ -364,7 +363,6 @@ public void testCrossClusterAddTotals() throws IOException {
364363
/** CrossClusterSearchIT Test for addcoltotals. */
365364
@Test
366365
public void testCrossClusterAddColTotals() throws IOException {
367-
// Test query_string without fields parameter on remote cluster
368366
JSONObject result =
369367
executeQuery(
370368
String.format(
@@ -377,7 +375,6 @@ public void testCrossClusterAddColTotals() throws IOException {
377375

378376
@Test
379377
public void testCrossClusterTranspose() throws IOException {
380-
// Test query_string without fields parameter on remote cluster
381378
JSONObject result =
382379
executeQuery(
383380
String.format(

0 commit comments

Comments
 (0)