Merge remote-tracking branch 'origin/main' into issues/4136

Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>

Author: yuancu

.github/ISSUE_TEMPLATE/docs-issue.md

@@ -0,0 +1,20 @@
+---
+name: 📃 Documentation issue
+about: Need docs? Create an issue to request or add new documentation.
+title: '[DOC]'
+labels: 'untriaged, documentation'
+assignees: ''
+---
+
+**What do you want to do?**
+
+- [ ] Request a change to existing documentation
+- [ ] Add new documentation
+- [ ] Report a technical problem with the documentation
+- [ ] Other
+  
+**Tell us about your request.** Provide a summary of the request.
+
+**Version:** List the OpenSearch version to which this issue applies, e.g. 2.14, 2.12--2.14, or all.
+
+**What other resources are available?** Provide links to related issues, POCs, steps for testing, etc.

DEVELOPER_GUIDE.rst

@@ -225,7 +225,9 @@ Building and Running Tests
 Gradle Build
 ------------
 
-Most of the time you just need to run ./gradlew build which will make sure you pass all checks and testing. While you're developing, you may want to run specific Gradle task only. In this case, you can run ./gradlew with task name which only triggers the task along with those it depends on. Here is a list for common tasks:
+Most of the time you just need to run ``./gradlew build`` which will make sure you pass all checks and testing. While you're developing, you may want to run specific Gradle task only. In this case, you can run ./gradlew with task name which only triggers the task along with those it depends on. Here is a list for common tasks:
+
+For faster local iterations, the build can skip integration and doctests. ``./gradlew build --parallel -x integTest -x doctest``.
 
 .. list-table::
    :widths: 30 50

async-query-core/build.gradle

@@ -85,6 +85,7 @@ spotless {
 }
 
 test {
+    maxParallelForks = Runtime.runtime.availableProcessors()
     useJUnitPlatform()
     testLogging {
         events "skipped", "failed"

async-query/build.gradle

@@ -53,6 +53,7 @@ dependencies {
 }
 
 test {
+    maxParallelForks = Runtime.runtime.availableProcessors()
     useJUnitPlatform {
         includeEngines("junit-jupiter")
     }
@@ -62,6 +63,7 @@ test {
     }
 }
 task junit4(type: Test) {
+    maxParallelForks = Runtime.runtime.availableProcessors()
     useJUnitPlatform {
         includeEngines("junit-vintage")
     }

core/build.gradle

@@ -94,6 +94,7 @@ spotless {
 }
 
 test {
+    maxParallelForks = Runtime.runtime.availableProcessors()
     useJUnitPlatform()
     testLogging {
         events "skipped", "failed"

core/src/main/java/org/opensearch/sql/analysis/Analyzer.java

@@ -10,7 +10,7 @@
 import static org.opensearch.sql.ast.tree.Sort.NullOrder.NULL_LAST;
 import static org.opensearch.sql.ast.tree.Sort.SortOrder.ASC;
 import static org.opensearch.sql.ast.tree.Sort.SortOrder.DESC;
-import static org.opensearch.sql.common.setting.Settings.Key.CALCITE_ENGINE_ENABLED;
+import static org.opensearch.sql.calcite.utils.CalciteUtils.getOnlyForCalciteException;
 import static org.opensearch.sql.data.type.ExprCoreType.DATE;
 import static org.opensearch.sql.data.type.ExprCoreType.STRUCT;
 import static org.opensearch.sql.data.type.ExprCoreType.TIME;
@@ -79,6 +79,7 @@
 import org.opensearch.sql.ast.tree.Patterns;
 import org.opensearch.sql.ast.tree.Project;
 import org.opensearch.sql.ast.tree.RareTopN;
+import org.opensearch.sql.ast.tree.Regex;
 import org.opensearch.sql.ast.tree.Relation;
 import org.opensearch.sql.ast.tree.RelationSubquery;
 import org.opensearch.sql.ast.tree.Rename;
@@ -87,6 +88,7 @@
 import org.opensearch.sql.ast.tree.Sort.SortOption;
 import org.opensearch.sql.ast.tree.SubqueryAlias;
 import org.opensearch.sql.ast.tree.TableFunction;
+import org.opensearch.sql.ast.tree.Timechart;
 import org.opensearch.sql.ast.tree.Trendline;
 import org.opensearch.sql.ast.tree.UnresolvedPlan;
 import org.opensearch.sql.ast.tree.Values;
@@ -181,8 +183,7 @@ public LogicalPlan visitSubqueryAlias(SubqueryAlias node, AnalysisContext contex
           STRUCT);
       return child;
     } else {
-      throw new UnsupportedOperationException(
-          "Subsearch is supported only when " + CALCITE_ENGINE_ENABLED.getKeyValue() + "=true");
+      throw getOnlyForCalciteException("Subsearch");
     }
   }
 
@@ -672,14 +673,12 @@ public LogicalPlan visitML(ML node, AnalysisContext context) {
 
   @Override
   public LogicalPlan visitBin(Bin node, AnalysisContext context) {
-    throw new UnsupportedOperationException(
-        "Bin command is supported only when " + CALCITE_ENGINE_ENABLED.getKeyValue() + "=true");
+    throw getOnlyForCalciteException("Bin");
   }
 
   @Override
   public LogicalPlan visitExpand(Expand expand, AnalysisContext context) {
-    throw new UnsupportedOperationException(
-        "Expand is supported only when " + CALCITE_ENGINE_ENABLED.getKeyValue() + "=true");
+    throw getOnlyForCalciteException("Expand");
   }
 
   /** Build {@link LogicalTrendline} for Trendline command. */
@@ -733,14 +732,22 @@ public LogicalPlan visitTrendline(Trendline node, AnalysisContext context) {
 
   @Override
   public LogicalPlan visitFlatten(Flatten node, AnalysisContext context) {
-    throw new UnsupportedOperationException(
-        "FLATTEN is supported only when " + CALCITE_ENGINE_ENABLED.getKeyValue() + "=true");
+    throw getOnlyForCalciteException("Flatten");
   }
 
   @Override
   public LogicalPlan visitReverse(Reverse node, AnalysisContext context) {
-    throw new UnsupportedOperationException(
-        "REVERSE is supported only when " + CALCITE_ENGINE_ENABLED.getKeyValue() + "=true");
+    throw getOnlyForCalciteException("Reverse");
+  }
+
+  @Override
+  public LogicalPlan visitTimechart(Timechart node, AnalysisContext context) {
+    throw getOnlyForCalciteException("Timechart");
+  }
+
+  @Override
+  public LogicalPlan visitRegex(Regex node, AnalysisContext context) {
+    throw getOnlyForCalciteException("Regex");
   }
 
   @Override
@@ -763,20 +770,17 @@ public LogicalPlan visitCloseCursor(CloseCursor closeCursor, AnalysisContext con
 
   @Override
   public LogicalPlan visitJoin(Join node, AnalysisContext context) {
-    throw new UnsupportedOperationException(
-        "Join is supported only when " + CALCITE_ENGINE_ENABLED.getKeyValue() + "=true");
+    throw getOnlyForCalciteException("Join");
   }
 
   @Override
   public LogicalPlan visitLookup(Lookup node, AnalysisContext context) {
-    throw new UnsupportedOperationException(
-        "Lookup is supported only when " + CALCITE_ENGINE_ENABLED.getKeyValue() + "=true");
+    throw getOnlyForCalciteException("Lookup");
   }
 
   @Override
   public LogicalPlan visitAppendCol(AppendCol node, AnalysisContext context) {
-    throw new UnsupportedOperationException(
-        "AppendCol is supported only when " + CALCITE_ENGINE_ENABLED.getKeyValue() + "=true");
+    throw getOnlyForCalciteException("Appendcol");
   }
 
   private LogicalSort buildSort(

core/src/main/java/org/opensearch/sql/analysis/ExpressionAnalyzer.java

@@ -7,7 +7,7 @@
 
 import static org.opensearch.sql.ast.dsl.AstDSL.and;
 import static org.opensearch.sql.ast.dsl.AstDSL.compare;
-import static org.opensearch.sql.common.setting.Settings.Key.CALCITE_ENGINE_ENABLED;
+import static org.opensearch.sql.calcite.utils.CalciteUtils.getOnlyForCalciteException;
 
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
@@ -435,20 +435,17 @@ public Expression visitArgument(Argument node, AnalysisContext context) {
 
   @Override
   public Expression visitScalarSubquery(ScalarSubquery node, AnalysisContext context) {
-    throw new UnsupportedOperationException(
-        "Subsearch is supported only when " + CALCITE_ENGINE_ENABLED.getKeyValue() + "=true");
+    throw getOnlyForCalciteException("Subsearch");
   }
 
   @Override
   public Expression visitExistsSubquery(ExistsSubquery node, AnalysisContext context) {
-    throw new UnsupportedOperationException(
-        "Subsearch is supported only when " + CALCITE_ENGINE_ENABLED.getKeyValue() + "=true");
+    throw getOnlyForCalciteException("Subsearch");
   }
 
   @Override
   public Expression visitInSubquery(InSubquery node, AnalysisContext context) {
-    throw new UnsupportedOperationException(
-        "Subsearch is supported only when " + CALCITE_ENGINE_ENABLED.getKeyValue() + "=true");
+    throw getOnlyForCalciteException("Subsearch");
   }
 
   /**

core/src/main/java/org/opensearch/sql/ast/AbstractNodeVisitor.java

@@ -67,6 +67,7 @@
 import org.opensearch.sql.ast.tree.Patterns;
 import org.opensearch.sql.ast.tree.Project;
 import org.opensearch.sql.ast.tree.RareTopN;
+import org.opensearch.sql.ast.tree.Regex;
 import org.opensearch.sql.ast.tree.Relation;
 import org.opensearch.sql.ast.tree.RelationSubquery;
 import org.opensearch.sql.ast.tree.Rename;
@@ -75,6 +76,7 @@
 import org.opensearch.sql.ast.tree.Sort;
 import org.opensearch.sql.ast.tree.SubqueryAlias;
 import org.opensearch.sql.ast.tree.TableFunction;
+import org.opensearch.sql.ast.tree.Timechart;
 import org.opensearch.sql.ast.tree.Trendline;
 import org.opensearch.sql.ast.tree.Values;
 import org.opensearch.sql.ast.tree.Window;
@@ -259,6 +261,14 @@ public T visitReverse(Reverse node, C context) {
     return visitChildren(node, context);
   }
 
+  public T visitTimechart(Timechart node, C context) {
+    return visitChildren(node, context);
+  }
+
+  public T visitRegex(Regex node, C context) {
+    return visitChildren(node, context);
+  }
+
   public T visitLambdaFunction(LambdaFunction node, C context) {
     return visitChildren(node, context);
   }

core/src/main/java/org/opensearch/sql/ast/tree/Regex.java

@@ -0,0 +1,55 @@
+/*
+ * Copyright OpenSearch Contributors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+package org.opensearch.sql.ast.tree;
+
+import com.google.common.collect.ImmutableList;
+import java.util.List;
+import lombok.EqualsAndHashCode;
+import lombok.Getter;
+import lombok.Setter;
+import lombok.ToString;
+import org.opensearch.sql.ast.AbstractNodeVisitor;
+import org.opensearch.sql.ast.expression.Literal;
+import org.opensearch.sql.ast.expression.UnresolvedExpression;
+
+@Getter
+@ToString
+@EqualsAndHashCode(callSuper = false)
+public class Regex extends UnresolvedPlan {
+  public static final String EQUALS_OPERATOR = "=";
+
+  public static final String NOT_EQUALS_OPERATOR = "!=";
+
+  private final UnresolvedExpression field;
+
+  private final boolean negated;
+
+  private final Literal pattern;
+
+  @Setter private UnresolvedPlan child;
+
+  public Regex(UnresolvedExpression field, boolean negated, Literal pattern) {
+    this.field = field;
+    this.negated = negated;
+    this.pattern = pattern;
+  }
+
+  @Override
+  public Regex attach(UnresolvedPlan child) {
+    this.child = child;
+    return this;
+  }
+
+  @Override
+  public List<UnresolvedPlan> getChild() {
+    return this.child == null ? ImmutableList.of() : ImmutableList.of(this.child);
+  }
+
+  @Override
+  public <T, C> T accept(AbstractNodeVisitor<T, C> nodeVisitor, C context) {
+    return nodeVisitor.visitRegex(this, context);
+  }
+}

core/src/main/java/org/opensearch/sql/ast/tree/Timechart.java

@@ -0,0 +1,65 @@
+/*
+ * Copyright OpenSearch Contributors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+package org.opensearch.sql.ast.tree;
+
+import com.google.common.collect.ImmutableList;
+import java.util.List;
+import lombok.AllArgsConstructor;
+import lombok.EqualsAndHashCode;
+import lombok.Getter;
+import lombok.ToString;
+import org.opensearch.sql.ast.AbstractNodeVisitor;
+import org.opensearch.sql.ast.expression.UnresolvedExpression;
+
+/** AST node represent Timechart operation. */
+@Getter
+@ToString
+@EqualsAndHashCode(callSuper = false)
+@AllArgsConstructor
+@lombok.Builder(toBuilder = true)
+public class Timechart extends UnresolvedPlan {
+  private UnresolvedPlan child;
+  private UnresolvedExpression binExpression;
+  private UnresolvedExpression aggregateFunction;
+  private UnresolvedExpression byField;
+  private Integer limit;
+  private Boolean useOther;
+
+  public Timechart(UnresolvedPlan child, UnresolvedExpression aggregateFunction) {
+    this(child, null, aggregateFunction, null, null, true);
+  }
+
+  public Timechart span(UnresolvedExpression binExpression) {
+    return toBuilder().binExpression(binExpression).build();
+  }
+
+  public Timechart by(UnresolvedExpression byField) {
+    return toBuilder().byField(byField).build();
+  }
+
+  public Timechart limit(Integer limit) {
+    return toBuilder().limit(limit).build();
+  }
+
+  public Timechart useOther(Boolean useOther) {
+    return toBuilder().useOther(useOther).build();
+  }
+
+  @Override
+  public Timechart attach(UnresolvedPlan child) {
+    return toBuilder().child(child).build();
+  }
+
+  @Override
+  public List<UnresolvedPlan> getChild() {
+    return ImmutableList.of(child);
+  }
+
+  @Override
+  public <T, C> T accept(AbstractNodeVisitor<T, C> nodeVisitor, C context) {
+    return nodeVisitor.visitTimechart(this, context);
+  }
+}