Decimal literal should convert to double in pushdown (opensearch-project#3811) (opensearch-project#3813)

* Decimal literal should convert to double in pushdown



* fix In expression



* fix style



---------


(cherry picked from commit e32c945)

Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Author: opensearch-trigger-bot[bot]

integ-test/src/yamlRestTest/resources/rest-api-spec/test/issues/3810.yml

@@ -0,0 +1,48 @@
+setup:
+  - do:
+      query.settings:
+        body:
+          transient:
+            plugins.calcite.enabled : true
+            plugins.calcite.fallback.allowed : false
+
+---
+teardown:
+  - do:
+      query.settings:
+        body:
+          transient:
+            plugins.calcite.enabled : false
+            plugins.calcite.fallback.allowed : true
+
+---
+"Decimal literal should convert to double in pushdown":
+  - skip:
+      features:
+        - headers
+  - do:
+      bulk:
+        index: test
+        refresh: true
+        body:
+          - '{"index": {}}'
+          - '{"balance": 1000}'
+  - do:
+      headers:
+        Content-Type: 'application/json'
+      ppl:
+        body:
+          query: 'source=test | where balance >= 1000.0 | stats avg(balance)'
+  - match: {"total": 1}
+  - match: {"schema": [{"name": "avg(balance)", "type": "double"}]}
+  - match: {"datarows": [[1000.0]]}
+
+  - do:
+      headers:
+        Content-Type: 'application/json'
+      ppl:
+        body:
+          query: 'source=test | where balance in (999.0, 1000.0) | stats avg(balance)'
+  - match: {"total": 1}
+  - match: {"schema": [{"name": "avg(balance)", "type": "double"}]}
+  - match: {"datarows": [[1000.0]]}

opensearch/src/main/java/org/opensearch/sql/opensearch/request/PredicateAnalyzer.java

@@ -40,6 +40,7 @@
 
 import com.google.common.base.Throwables;
 import com.google.common.collect.Range;
+import java.math.BigDecimal;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.GregorianCalendar;
@@ -1065,7 +1066,7 @@ Object value() {
         return sargValue();
       } else if (isIntegral()) {
         return longValue();
-      } else if (isFloatingPoint()) {
+      } else if (isFractional()) {
         return doubleValue();
       } else if (isBoolean()) {
         return booleanValue();
@@ -1080,8 +1081,8 @@ boolean isIntegral() {
       return SqlTypeName.INT_TYPES.contains(literal.getType().getSqlTypeName());
     }
 
-    boolean isFloatingPoint() {
-      return SqlTypeName.APPROX_TYPES.contains(literal.getType().getSqlTypeName());
+    boolean isFractional() {
+      return SqlTypeName.FRACTIONAL_TYPES.contains(literal.getType().getSqlTypeName());
     }
 
     boolean isBoolean() {
@@ -1132,6 +1133,8 @@ Object sargPointValue(Object point, SqlTypeName sqlTypeName) {
         case CHAR:
         case VARCHAR:
           return ((NlsString) point).getValue();
+        case DECIMAL:
+          return ((BigDecimal) point).doubleValue();
         default:
           return point;
       }