Skip to content

Commit 42fd079

Browse files
committed
Update error messages of datetime functions with invalid args
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
1 parent 6c3faa4 commit 42fd079

1 file changed

Lines changed: 5 additions & 9 deletions

File tree

ppl/src/test/java/org/opensearch/sql/ppl/calcite/CalcitePPLFunctionTypeTest.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,7 @@ public void testTimeDiffWithUdtInputType() {
3535
getRelNode(timePpl);
3636
Throwable t = Assert.assertThrows(Exception.class, () -> getRelNode(wrongPpl));
3737
verifyErrorMessageContains(
38-
t,
39-
"TIMEDIFF function expects"
40-
+ " {[STRING,STRING],[DATE,DATE],[DATE,TIME],[DATE,TIMESTAMP],[TIME,DATE],[TIME,TIME],[TIME,TIMESTAMP],"
41-
+ "[TIMESTAMP,DATE],[TIMESTAMP,TIME],[TIMESTAMP,TIMESTAMP],[DATE,STRING],[TIME,STRING],[TIMESTAMP,STRING],[STRING,DATE],[STRING,TIME],[STRING,TIMESTAMP]},"
42-
+ " but got [INTEGER,STRING]");
38+
t, "TIMEDIFF function expects {[TIME,TIME]}, but got [INTEGER,STRING]");
4339
}
4440

4541
@Test
@@ -104,10 +100,10 @@ public void testTimestampWithWrongArg() {
104100
Throwable t = Assert.assertThrows(ExpressionEvaluationException.class, () -> getRelNode(ppl));
105101
verifyErrorMessageContains(
106102
t,
107-
"TIMESTAMP function expects"
108-
+ " {[STRING],[DATE],[TIME],[TIMESTAMP],[STRING,STRING],[DATE,DATE],[DATE,TIME],[DATE,TIMESTAMP],"
109-
+ "[TIME,DATE],[TIME,TIME],[TIME,TIMESTAMP],[TIMESTAMP,DATE],[TIMESTAMP,TIME],[TIMESTAMP,TIMESTAMP]"
110-
+ ",[STRING,DATE],[STRING,TIME],[STRING,TIMESTAMP],[DATE,STRING],[TIME,STRING],[TIMESTAMP,STRING]},"
103+
"TIMESTAMP function expects {"
104+
+ "[STRING],[TIMESTAMP],[DATE],[TIME],[STRING,STRING],[TIMESTAMP,TIMESTAMP],[TIMESTAMP,DATE],"
105+
+ "[TIMESTAMP,TIME],[DATE,TIMESTAMP],[DATE,DATE],[DATE,TIME],[TIME,TIMESTAMP],[TIME,DATE],"
106+
+ "[TIME,TIME],[STRING,TIMESTAMP],[STRING,DATE],[STRING,TIME],[TIMESTAMP,STRING],[DATE,STRING],[TIME,STRING]},"
111107
+ " but got [STRING,INTEGER]");
112108
}
113109

0 commit comments

Comments
 (0)