Skip to content

Commit 7b3fdc6

Browse files
committed
Remove stale resolveSafe function
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
1 parent d89c911 commit 7b3fdc6

2 files changed

Lines changed: 1 addition & 11 deletions

File tree

core/src/main/java/org/opensearch/sql/calcite/CalciteRexNodeVisitor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ public RexNode visitFunction(Function node, CalcitePlanContext context) {
338338
List<RexNode> arguments =
339339
node.getFuncArgs().stream().map(arg -> analyze(arg, context)).toList();
340340
RexNode resolvedNode =
341-
PPLFuncImpTable.INSTANCE.resolveSafe(
341+
PPLFuncImpTable.INSTANCE.resolve(
342342
context.rexBuilder, node.getFuncName(), arguments.toArray(new RexNode[0]));
343343
if (resolvedNode != null) {
344344
return resolvedNode;

core/src/main/java/org/opensearch/sql/expression/function/PPLFuncImpTable.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import org.apache.calcite.sql.fun.SqlTrimFunction.Flag;
2727
import org.apache.calcite.sql.type.SqlTypeName;
2828
import org.apache.commons.lang3.tuple.Pair;
29-
import org.checkerframework.checker.nullness.qual.Nullable;
3029
import org.opensearch.sql.executor.QueryType;
3130

3231
public class PPLFuncImpTable {
@@ -133,15 +132,6 @@ public void registerExternalFunction(BuiltinFunctionName functionName, FunctionI
133132
}
134133
}
135134

136-
public @Nullable RexNode resolveSafe(
137-
final RexBuilder builder, final String functionName, RexNode... args) {
138-
try {
139-
return resolve(builder, functionName, args);
140-
} catch (Exception e) {
141-
return null;
142-
}
143-
}
144-
145135
public RexNode resolve(final RexBuilder builder, final String functionName, RexNode... args) {
146136
Optional<BuiltinFunctionName> funcNameOpt = BuiltinFunctionName.of(functionName);
147137
if (funcNameOpt.isEmpty()) {

0 commit comments

Comments
 (0)