Display PPL types when failing to resolve a function

Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>

Author: yuancu

core/src/main/java/org/opensearch/sql/exception/ExpressionEvaluationException.java

@@ -7,7 +7,12 @@
 
 /** Exception for Expression Evaluation. */
 public class ExpressionEvaluationException extends QueryEngineException {
+
   public ExpressionEvaluationException(String message) {
     super(message);
   }
+
+  public ExpressionEvaluationException(String message, Throwable cause) {
+    super(message, cause);
+  }
 }

core/src/main/java/org/opensearch/sql/expression/function/PPLFuncImpTable.java

@@ -146,26 +146,29 @@ public RexNode resolve(
         }
       }
     } catch (Exception e) {
-      throw new IllegalArgumentException(
+      throw new ExpressionEvaluationException(
           String.format(
               "Cannot resolve function: %s, arguments: %s, caused by: %s",
-              functionName, argTypes, e.getMessage()),
+              functionName, getActualSignature(argTypes), e.getMessage()),
           e);
     }
-    StringJoiner joiner = new StringJoiner(",");
+    StringJoiner allowedSignatures = new StringJoiner(",");
     for (var implement : implementList) {
-      joiner.add(implement.getKey().typeChecker().getAllowedSignatures());
+      allowedSignatures.add(implement.getKey().typeChecker().getAllowedSignatures());
     }
-    String actualSignature =
-        "["
-            + argTypes.stream()
-                .map(OpenSearchTypeFactory::convertRelDataTypeToExprType)
-                .map(Objects::toString)
-                .collect(Collectors.joining(","))
-            + "]";
     throw new ExpressionEvaluationException(
         String.format(
-            "%s function expects {%s}, but got %s", functionName, joiner, actualSignature));
+            "%s function expects {%s}, but got %s",
+            functionName, allowedSignatures, getActualSignature(argTypes)));
+  }
+
+  private static String getActualSignature(List<RelDataType> argTypes) {
+    return "["
+        + argTypes.stream()
+            .map(OpenSearchTypeFactory::convertRelDataTypeToExprType)
+            .map(Objects::toString)
+            .collect(Collectors.joining(","))
+        + "]";
   }
 
   @SuppressWarnings({"UnusedReturnValue", "SameParameterValue"})

ppl/src/test/java/org/opensearch/sql/ppl/calcite/CalcitePPLFunctionTypeTest.java

@@ -87,10 +87,11 @@ public void testIfWithWrongType() {
     String pplIncompatibleType =
         "source=EMP | eval if_name = if(EMPNO > 6, 'Jack', 1) | fields if_name";
     Throwable t2 =
-        Assert.assertThrows(IllegalArgumentException.class, () -> getRelNode(pplIncompatibleType));
+        Assert.assertThrows(
+            ExpressionEvaluationException.class, () -> getRelNode(pplIncompatibleType));
     verifyErrorMessageContains(
         t2,
-        "Cannot resolve function: IF, arguments: [BOOLEAN, VARCHAR, INTEGER], caused by: Can't find"
+        "Cannot resolve function: IF, arguments: [BOOLEAN,STRING,INTEGER], caused by: Can't find"
             + " leastRestrictive type for [VARCHAR, INTEGER]");
   }