Skip to content

Commit 91aaee8

Browse files
committed
Ignore testNestedAggregationsExplain when pushdown is disabled
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
1 parent 3b65b2d commit 91aaee8

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteExplainIT.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1230,8 +1230,10 @@ public void testCasePushdownAsRangeQueryExplain() throws IOException {
12301230

12311231
@Test
12321232
public void testNestedAggregationsExplain() throws IOException {
1233-
// the query runs into error when pushdown is disabled due to bin's implementation
1234-
Assume.assumeFalse(isPushdownDisabled());
1233+
// TODO: Remove after resolving: https://github.com/opensearch-project/sql/issues/4578
1234+
Assume.assumeFalse(
1235+
"The query runs into error when pushdown is disabled due to bin's implementation",
1236+
isPushdownDisabled());
12351237
assertYamlEqualsJsonIgnoreId(
12361238
loadExpectedPlan("agg_composite_autodate_range_metric_push.yaml"),
12371239
explainQueryToString(

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalcitePPLCaseFunctionIT.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import java.io.IOException;
2020
import org.json.JSONObject;
21+
import org.junit.Assume;
2122
import org.junit.jupiter.api.Test;
2223
import org.opensearch.client.Request;
2324
import org.opensearch.sql.legacy.TestsConstants;
@@ -476,6 +477,11 @@ public void testCaseAggWithNullValues() throws IOException {
476477

477478
@Test
478479
public void testNestedCaseAggWithAutoDateHistogram() throws IOException {
480+
// TODO: Remove after resolving: https://github.com/opensearch-project/sql/issues/4578
481+
Assume.assumeFalse(
482+
"The query cannot be executed when pushdown is disabled due to implementation defects of"
483+
+ " the bin command",
484+
isPushdownDisabled());
479485
JSONObject actual1 =
480486
executeQuery(
481487
String.format(

0 commit comments

Comments
 (0)