Skip to content

Commit 9fcf8c3

Browse files
committed
Update operand types for percentile approx to allow with addtional type hint
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
1 parent 67d9ea6 commit 9fcf8c3

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

core/src/main/java/org/opensearch/sql/calcite/utils/PPLOperandTypes.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,12 +117,15 @@ private PPLOperandTypes() {}
117117
(OperandTypes.family(SqlTypeFamily.NUMERIC, SqlTypeFamily.STRING))
118118
.or(OperandTypes.family(SqlTypeFamily.STRING, SqlTypeFamily.STRING)));
119119

120-
public static final UDFOperandMetadata NUMERIC_NUMERIC_OPTIONAL_NUMERIC =
120+
public static final UDFOperandMetadata NUMERIC_NUMERIC_OPTIONAL_NUMERIC_SYMBOL =
121121
UDFOperandMetadata.wrap(
122-
(CompositeOperandTypeChecker)
123-
OperandTypes.NUMERIC_NUMERIC.or(
122+
OperandTypes.family(SqlTypeFamily.NUMERIC, SqlTypeFamily.NUMERIC, SqlTypeFamily.ANY)
123+
.or(
124124
OperandTypes.family(
125-
SqlTypeFamily.NUMERIC, SqlTypeFamily.NUMERIC, SqlTypeFamily.NUMERIC)));
125+
SqlTypeFamily.NUMERIC,
126+
SqlTypeFamily.NUMERIC,
127+
SqlTypeFamily.NUMERIC,
128+
SqlTypeFamily.ANY)));
126129
public static final UDFOperandMetadata NUMERIC_NUMERIC_NUMERIC =
127130
UDFOperandMetadata.wrap(
128131
OperandTypes.family(SqlTypeFamily.NUMERIC, SqlTypeFamily.NUMERIC, SqlTypeFamily.NUMERIC));

core/src/main/java/org/opensearch/sql/expression/function/PPLBuiltinOperators.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ public class PPLBuiltinOperators extends ReflectiveSqlOperatorTable {
465465
PercentileApproxFunction.class,
466466
"percentile_approx",
467467
ReturnTypes.ARG0_FORCE_NULLABLE,
468-
PPLOperandTypes.NUMERIC_NUMERIC_OPTIONAL_NUMERIC);
468+
PPLOperandTypes.NUMERIC_NUMERIC_OPTIONAL_NUMERIC_SYMBOL);
469469
public static final SqlAggFunction INTERNAL_PATTERN =
470470
createUserDefinedAggFunction(
471471
LogPatternAggFunction.class,

0 commit comments

Comments
 (0)