Skip to content

Commit b204b2e

Browse files
committed
Fix unit tests
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
1 parent f690add commit b204b2e

3 files changed

Lines changed: 15 additions & 7 deletions

File tree

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalcitePPLCaseFunctionIT.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import static org.junit.jupiter.api.Assertions.assertTrue;
99
import static org.opensearch.sql.legacy.TestsConstants.TEST_INDEX_BANK;
1010
import static org.opensearch.sql.legacy.TestsConstants.TEST_INDEX_WEBLOGS;
11+
import static org.opensearch.sql.util.MatcherUtils.closeTo;
1112
import static org.opensearch.sql.util.MatcherUtils.rows;
1213
import static org.opensearch.sql.util.MatcherUtils.schema;
1314
import static org.opensearch.sql.util.MatcherUtils.verifyDataRows;
@@ -304,9 +305,9 @@ public void testCaseCanBePushedDownAsRangeQuery() throws IOException {
304305
verifySchema(actual4, schema("avg(balance)", "double"), schema("age_range", "string"));
305306
verifyDataRows(
306307
actual4,
307-
rows(32838.0, "u30"),
308-
rows(30497.0, "null"),
309-
rows(20881.333333333332, "30-40 or >=80"));
308+
closeTo(32838.0, "u30"),
309+
closeTo(30497.0, "null"),
310+
closeTo(20881.333333333332, "30-40 or >=80"));
310311

311312
// 1.5 Should not be pushed because the range is not closed-open
312313
JSONObject actual5 =

opensearch/src/main/java/org/opensearch/sql/opensearch/response/agg/LeafBucketAggregationParser.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,9 @@ private Map<String, Object> parse(MultiBucketsAggregation.Bucket bucket, String
6464
if (bucket.getDocCount() == 0) {
6565
return null;
6666
}
67-
result.put(name, bucket.getKey());
6867
}
68+
// TODO: Should we add all bucket key to agg name? It does not always seem necessary.
69+
result.put(name, bucket.getKey());
6970
countAggNameList.forEach(n -> result.put(n, bucket.getDocCount()));
7071
return result;
7172
}

opensearch/src/test/java/org/opensearch/sql/opensearch/request/AggregateAnalyzerTest.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,9 @@
4646
import org.opensearch.sql.opensearch.data.type.OpenSearchDataType;
4747
import org.opensearch.sql.opensearch.data.type.OpenSearchDataType.MappingType;
4848
import org.opensearch.sql.opensearch.request.AggregateAnalyzer.ExpressionNotAnalyzableException;
49-
import org.opensearch.sql.opensearch.response.agg.CompositeAggregationParser;
49+
import org.opensearch.sql.opensearch.response.agg.BucketAggregationParser;
5050
import org.opensearch.sql.opensearch.response.agg.FilterParser;
51+
import org.opensearch.sql.opensearch.response.agg.LeafBucketAggregationParser;
5152
import org.opensearch.sql.opensearch.response.agg.MetricParserHelper;
5253
import org.opensearch.sql.opensearch.response.agg.NoBucketAggregationParser;
5354
import org.opensearch.sql.opensearch.response.agg.OpenSearchAggregationResponseParser;
@@ -280,9 +281,14 @@ void analyze_groupBy() throws ExpressionNotAnalyzableException {
280281
+ "{\"a\":{\"terms\":{\"field\":\"a\",\"missing_bucket\":true,\"missing_order\":\"first\",\"order\":\"asc\"}}},"
281282
+ "{\"b\":{\"terms\":{\"field\":\"b.keyword\",\"missing_bucket\":true,\"missing_order\":\"first\",\"order\":\"asc\"}}}]}}}]",
282283
result.getLeft().toString());
283-
assertInstanceOf(CompositeAggregationParser.class, result.getRight());
284+
assertInstanceOf(BucketAggregationParser.class, result.getRight());
285+
assertInstanceOf(
286+
LeafBucketAggregationParser.class,
287+
((BucketAggregationParser) result.getRight()).getSubAggParser());
284288
MetricParserHelper metricsParser =
285-
((CompositeAggregationParser) result.getRight()).getMetricsParser();
289+
((LeafBucketAggregationParser)
290+
((BucketAggregationParser) result.getRight()).getSubAggParser())
291+
.getMetricsParser();
286292
assertEquals(1, metricsParser.getMetricParserMap().size());
287293
metricsParser
288294
.getMetricParserMap()

0 commit comments

Comments
 (0)