Skip to content

Commit d40c244

Browse files
committed
Remove an unnecessary bucket agg in AggregationQueryBuilder
Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
1 parent 6beed21 commit d40c244

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

opensearch/src/main/java/org/opensearch/sql/opensearch/storage/script/aggregation/AggregationQueryBuilder.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
import org.opensearch.sql.expression.ReferenceExpression;
3030
import org.opensearch.sql.expression.aggregation.NamedAggregator;
3131
import org.opensearch.sql.opensearch.data.type.OpenSearchDataType;
32-
import org.opensearch.sql.opensearch.response.agg.BucketAggregationParser;
3332
import org.opensearch.sql.opensearch.response.agg.LeafBucketAggregationParser;
3433
import org.opensearch.sql.opensearch.response.agg.MetricParser;
3534
import org.opensearch.sql.opensearch.response.agg.NoBucketAggregationParser;
@@ -96,7 +95,7 @@ public AggregationQueryBuilder(ExpressionSerializer serializer) {
9695
bucketNullable))
9796
.subAggregations(metrics.getLeft())
9897
.size(AGGREGATION_BUCKET_SIZE)),
99-
new BucketAggregationParser(new LeafBucketAggregationParser(metrics.getRight())));
98+
new LeafBucketAggregationParser(metrics.getRight()));
10099
}
101100
}
102101

opensearch/src/test/java/org/opensearch/sql/opensearch/storage/scan/OpenSearchIndexScanOptimizationTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@
7474
import org.opensearch.sql.expression.function.OpenSearchFunctions;
7575
import org.opensearch.sql.opensearch.data.type.OpenSearchDataType;
7676
import org.opensearch.sql.opensearch.request.OpenSearchRequestBuilder;
77-
import org.opensearch.sql.opensearch.response.agg.BucketAggregationParser;
7877
import org.opensearch.sql.opensearch.response.agg.LeafBucketAggregationParser;
7978
import org.opensearch.sql.opensearch.response.agg.OpenSearchAggregationResponseParser;
8079
import org.opensearch.sql.opensearch.response.agg.SingleValueParser;
@@ -804,8 +803,7 @@ private Runnable withAggregationPushedDown(
804803
.size(AggregationQueryBuilder.AGGREGATION_BUCKET_SIZE);
805804
List<AggregationBuilder> aggBuilders = Collections.singletonList(aggBuilder);
806805
responseParser =
807-
new BucketAggregationParser(
808-
new LeafBucketAggregationParser(new SingleValueParser(aggregation.aggregateName)));
806+
new LeafBucketAggregationParser(new SingleValueParser(aggregation.aggregateName));
809807

810808
return () -> {
811809
verify(requestBuilder, times(1)).pushDownAggregation(Pair.of(aggBuilders, responseParser));

0 commit comments

Comments
 (0)