filter split golf branch high to drop statement-deleting files#5
Open
Thmoas-Guan wants to merge 3 commits into
Open
filter split golf branch high to drop statement-deleting files#5Thmoas-Guan wants to merge 3 commits into
Thmoas-Guan wants to merge 3 commits into
Conversation
Thmoas-Guan
commented
Apr 24, 2026
| congr 1 | ||
| simp [Under.map, Comma.mapLeft] | ||
| rfl | ||
| simp [precompEnrichedHom'] |
Collaborator
Author
There was a problem hiding this comment.
This should be simp only, so actually no golf is done
| cases Z | ||
| rcases f with ⟨⟨⟨⟩⟩⟩ | ||
| exact g | ||
| comp g f := ULift.up (PLift.up (g.down.down.trans f.down.down)) |
Collaborator
Author
There was a problem hiding this comment.
Should be more careful when editing definitions.
Comment on lines
+334
to
+335
| map₂_comp := by intro _ _ _ _ _ η θ; exact Quot.induction_on₂ η θ fun _ _ => rfl | ||
| map₂_whisker_left := by intro _ _ _ _ _ _ η; exact Quot.induction_on η fun _ => by cat_disch |
Collaborator
Author
There was a problem hiding this comment.
This is a restate of the original proof, still need examination
| calc | ||
| _ = h ◁ (i.inv ≫ i.hom).right := by simp [-Iso.inv_hom_id] | ||
| _ = 𝟙 _ := by simp [Iso.inv_hom_id]) | ||
| (whiskering h).mapIso i |
Collaborator
Author
There was a problem hiding this comment.
Is this properly tested?
Comment on lines
+57
to
+58
| ext; simp [mapComp', F.mapComp_id_left_hom f, Strict.leftUnitor_eqToIso, | ||
| PrelaxFunctor.map₂_eqToHom] |
Collaborator
Author
There was a problem hiding this comment.
Modulo use of ; it looks like an improvement, similar above
| simp only [O, H, Finset.mem_biUnion, Finset.mem_univ, Finset.mem_image, | ||
| PSigma.mk.injEq, true_and, exists_and_left] | ||
| exact ⟨j, rfl, j', g, by simp⟩ | ||
| aesop (add simp [H]) |
Collaborator
Author
There was a problem hiding this comment.
Whether aesop is correctly used here needs discussion
Comment on lines
+339
to
+340
| Final F := | ||
| (isConnected_iff_final_of_unique F).mp (IsFiltered.isConnected C) |
Collaborator
Author
There was a problem hiding this comment.
looks good, similar below
| refine FilteredClosureSmall.InductiveStep.max ?_ ?_ x y | ||
| all_goals apply Nat.lt_succ_of_le | ||
| exacts [Nat.le_max_left _ _, Nat.le_max_right _ _] | ||
| exact FilteredClosureSmall.InductiveStep.max (by omega) (by omega) x y |
Collaborator
Author
There was a problem hiding this comment.
This is somehow really violating readability? This needs some further examination
| slice_lhs 2 3 => rw [NatTrans.naturality] | ||
| slice_lhs 1 2 => rw [← NatTrans.comp_app, NatTrans.naturality, NatTrans.comp_app] | ||
| rw [Category.assoc] } | ||
| naturality := fun X Y f => by cat_disch } |
Collaborator
Author
There was a problem hiding this comment.
I remember in this case cat_disch is prefered, so OK here
| symm | ||
| apply hc.uniq (c.extend _) | ||
| simp | ||
| have : g₁.right = g₂.right := hc.hom_ext this |
Collaborator
Author
There was a problem hiding this comment.
This is definitely improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
base: 0915ed3
kept_files: 131
removed_files: 22
rule: drop files whose patch deletes top-level def/lemma/theorem/instance/abbrev/class/structure declarations