Fix tablet-report-parser.pl for K8s support bundle tablet reports#198
Open
jasonriddell wants to merge 1 commit into
Open
Fix tablet-report-parser.pl for K8s support bundle tablet reports#198jasonriddell wants to merge 1 commit into
jasonriddell wants to merge 1 commit into
Conversation
K8s universe-details.json uses pod FQDNs as private_ip and omits nodeUuid from nodeDetailsSet. This caused two issues: 1. Fatal error matching entities replica IPs to universe nodes, since pod IPs never match FQDNs. 2. Empty node_uuid in the tablet table, causing UNIQUE constraint failures for replicated tablets. Fix: fall back to nodeName as node identifier when nodeUuid is absent, and warn instead of dying when entities IPs can't be matched to universe nodes. Co-authored-by: Cursor <cursoragent@cursor.com>
eugeneckim
approved these changes
Mar 2, 2026
Contributor
There was a problem hiding this comment.
I looked at this and these do appear to be low risk changes. I'm not married to the following list of things (hence approving):
- Print an info/warn when the fallback to nodeName is being used (and what value is being used).
- When the warning finds a mis match, it might be helpful (if not too heavy a lift) to print the specific mismatches.
- Finally, the previous behaviour was to die and i think we'd no longer die with the new behaviour. Do we need to preserve any of the death type behaviour within the if else if logic?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
private_ip(pod FQDNs) in Kubernetes deployments. Changeddieto a warning so the script continues.node_uuidin the tablet table by falling back tonodeNamewhennodeUuidis absent from K8suniverse-details.json, which also resolves UNIQUE constraint failures for replicated tablets.Closes #197
Test plan
node_uuidis populated in the tablet table (using nodeName as identifier)tablet(node_uuid, tablet_uuid)nodeUuidis present so the||=fallback is never triggered, and IP-based matching succeeds as beforeMade with Cursor