Closed
Conversation
…n, migrate to pyproject.toml Co-authored-by: yutaka551 <1833002+yutaka551@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues raised in pull request comments
Fix OctoPrint plugin registry review issues
Feb 23, 2026
…in implementation with settings template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from the OctoPrint plugin registry PR review. Several code quality and structural issues were identified that needed resolving before the plugin can be listed.
__init__.pyfrom lywsd03mmc import Lywsd03mmcClientto module level; removed the redundant per-callImportErrortry/catch — the library is declared as a dependency so it's always presentAssetPlugin: Dropped from class inheritance and removed the emptyget_assets()method entirelyplotlyGraphLywsd03mmc→plotly_graph_lywsd03mmcto matchplugin_identifierin setupProject packaging
pyproject.toml: Replaced verbose legacysetup.pywith the modern OctoPrint cookiecutter format;setup.pyis now a one-liner forsetuptools<77license compatibilityplugin_author_emailfieldAGPLv3leftover from the cookiecutter template toMIT, matching theLICENSEfile and READMEWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/OctoPrint/plugins.octoprint.org/issues/comments/3940399674/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.