Skip to content

Fix OctoPrint plugin registry review issues#5

Closed
Copilot wants to merge 8 commits intomainfrom
copilot/fix-comments-in-pull-request
Closed

Fix OctoPrint plugin registry review issues#5
Copilot wants to merge 8 commits intomainfrom
copilot/fix-comments-in-pull-request

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 23, 2026

Addresses feedback from the OctoPrint plugin registry PR review. Several code quality and structural issues were identified that needed resolving before the plugin can be listed.

__init__.py

  • Top-level import: Moved from lywsd03mmc import Lywsd03mmcClient to module level; removed the redundant per-call ImportError try/catch — the library is declared as a dependency so it's always present
  • Remove AssetPlugin: Dropped from class inheritance and removed the empty get_assets() method entirely
  • Fix software update key: plotlyGraphLywsd03mmcplotly_graph_lywsd03mmc to match plugin_identifier in setup

Project packaging

  • Migrate to pyproject.toml: Replaced verbose legacy setup.py with the modern OctoPrint cookiecutter format; setup.py is now a one-liner for setuptools<77 license compatibility
  • Add author email: Populated the previously empty plugin_author_email field
  • License consistency: Corrected AGPLv3 leftover from the cookiecutter template to MIT, matching the LICENSE file and README

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/OctoPrint/plugins.octoprint.org/issues/comments/3940399674
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…n, migrate to pyproject.toml

Co-authored-by: yutaka551 <1833002+yutaka551@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issues raised in pull request comments Fix OctoPrint plugin registry review issues Feb 23, 2026
Copilot AI requested a review from yutaka551 February 23, 2026 00:14
@yutaka551 yutaka551 closed this Feb 25, 2026
@yutaka551 yutaka551 deleted the copilot/fix-comments-in-pull-request branch February 25, 2026 12:55
@yutaka551 yutaka551 restored the copilot/fix-comments-in-pull-request branch February 25, 2026 13:41
@yutaka551 yutaka551 deleted the copilot/fix-comments-in-pull-request branch February 25, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants