refactor(ui): migrate icons to Next Image and remove inline auto sizing#2
Open
tenSunFree wants to merge 3 commits into
Open
refactor(ui): migrate icons to Next Image and remove inline auto sizing#2tenSunFree wants to merge 3 commits into
tenSunFree wants to merge 3 commits into
Conversation
yyyyyyy4
force-pushed
the
main
branch
27 times, most recently
from
84844c3 to
d438aa9
Compare
yyyyyyy4
force-pushed
the
main
branch
30 times, most recently
from
caf3e70 to
e49252d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate SVG icons from![]()
to next/image for consistency in the Hero section:
camp.svg, star.svg, close.svg
Remove inline style={{ width: 'auto', height: 'auto' }} to avoid overriding sizing and causing unpredictable layout.
Normalize icon sizing with Tailwind classes:
Camp: w-10 h-10 → lg:w-[50px] lg:h-[50px]
Star/Close: w-6 h-6 (24px)
Use unoptimized for SVG icons since they don’t benefit much from Next image optimization.