Skip to content

chore commit #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noorsk-dev wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore commit #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7af23b
ci(e2e): use ok-to-test action for permission checks
zakisk Mar 31, 2026
a925781
chore commit
noorsk-dev Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
206 changes: 0 additions & 206 deletions .github/scripts/check-pr-permissions.js
View file
Open in desktop

This file was deleted.

9 changes: 2 additions & 7 deletions .github/workflows/e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ on:
- ".github/workflows/**"
- "test/testdata/**"
- "vendor/**"
- ".github/scripts/**"

jobs:
e2e-tests:
Expand Down Expand Up @@ -127,15 +126,11 @@ jobs:
with:
ref: ${{ inputs.target_ref || github.event.pull_request.head.sha || github.sha }}

# Step to check PR author's org membership and repo permissions.
# This step will fail the job if checks do not pass, skipping subsequent steps.
- name: Check user permissions on PRs
if: github.event_name == 'pull_request_target'
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8
uses: pipelines-as-code/ok-to-test@v1
with:
script: |
const script = require('./.github/scripts/check-pr-permissions.js')
await script({github, context, core})
team-slugs: ${{ env.TARGET_TEAM_SLUGS }}

- uses: actions/setup-go@4b73464bb391d4059bd26b0524d20df3927bd417 # v6
with:
Expand Down
1 change: 1 addition & 0 deletions pkg/adapter/adapter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import (
"knative.dev/pkg/system"
)


@gemini-code-assist gemini-code-assist Bot Mar 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change adds an unnecessary blank line without any functional improvement or explanation. Per the project's contribution guidelines mentioned in the PR description, 'slop' or low-value changes should be avoided. Please remove this line and ensure the PR has a clear and meaningful purpose.

const globalAdapterPort = "8082"

// For incoming webhook requests and GitHub Apps with many installations the handler takes long
Expand Down
Loading