deployment is required for CI/CD pipeline checks

Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>

Author: szuecs

controller/stack_resources.go

@@ -44,10 +44,6 @@ func isOwned(ownerReferences []metav1.OwnerReference) (bool, types.UID) {
 func (c *StackSetController) ReconcileStackDeployment(ctx context.Context, stack *zv1.Stack, existing *apps.Deployment, generateUpdated func() *apps.Deployment) error {
 	deployment := generateUpdated()
 
-	if deployment == nil {
-		return nil
-	}
-
 	// Create new deployment
 	if existing == nil {
 		_, err := c.client.AppsV1().Deployments(deployment.Namespace).Create(ctx, deployment, metav1.CreateOptions{})

pkg/core/stack_resources.go

@@ -196,9 +196,6 @@ func (sc *StackContainer) selector() map[string]string {
 // "zalando.org/forward-backend", the deployment will be set to
 // replicas 1.
 func (sc *StackContainer) GenerateDeployment() *appsv1.Deployment {
-	if _, clusterMigration := sc.Stack.Annotations[forwardBackendAnnotation]; clusterMigration {
-		return nil
-	}
 
 	stack := sc.Stack
 
@@ -237,6 +234,12 @@ func (sc *StackContainer) GenerateDeployment() *appsv1.Deployment {
 		Labels:      embeddedCopy.Labels,
 	}
 
+	if _, clusterMigration := sc.Stack.Annotations[forwardBackendAnnotation]; clusterMigration && *updatedReplicas != 0 {
+		updatedReplicas = wrapReplicas(1)
+		sc.deploymentReplicas = 1
+		sc.stackReplicas = 1
+	}
+
 	deployment := &appsv1.Deployment{
 		ObjectMeta: sc.resourceMeta(),
 		Spec: appsv1.DeploymentSpec{