-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add publish of helm chart to ghcr.io #2853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
a1994sc
wants to merge
6
commits into
zalando:master
Choose a base branch
from
a1994sc:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12
−0
Open
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
90f1cc9
feat: add publish of helm chart to ghcr.io
a1994sc 7cdf692
Merge branch 'master' into master
a1994sc c9ed36f
Merge branch 'master' into master
a1994sc 0562716
Merge branch 'master' into master
a1994sc 6faa7fb
Merge branch 'master' into master
a1994sc 1fac45b
Merge branch 'master' into master
FxKu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this work out of the box? I would assume helm needs to be installed first fr this GH workflow step to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helm is installed by default on the github runners:
https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FxKu
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a1994sc Sorry, helm is usually not a priority for us. Don't you need a login step like
helm registry login ...or is this already covered with the existing login step?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helm will use the docker config setup by the
docker/login-actionaction you use to publish the docker imagesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do keep past releases of the helm chart in the chart directories. When you run helm package it would include all releases in the zipped file, right? Should it maybe only contain the last release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I call
helm packagewhich creates the tar ball in the root of the repo, then pushes that to the ghcr registry. As a result, there should be no major concern with leaving those past releases in place