test: add unit tests for validate() and NewFromMap() functions#3086
Open
raphaeltorquat0 wants to merge 1 commit intozalando:masterfrom
Open
test: add unit tests for validate() and NewFromMap() functions#3086raphaeltorquat0 wants to merge 1 commit intozalando:masterfrom
raphaeltorquat0 wants to merge 1 commit intozalando:masterfrom
Conversation
This addresses issue zalando#416 by adding comprehensive unit tests for the config utility functions: - TestValidate: Tests validation logic for MinInstances/MaxInstances, Workers count, ConnectionPooler instances, and user conflicts - TestNewFromMap: Tests config creation from map with defaults, custom values, duration/boolean/map/slice parsing, and panic behavior - TestMain: Sets OPERATOR_NAMESPACE env var for testing outside K8s The tests cover both valid configurations and error cases.
Author
|
Hi @FxKu, could you please add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate()andNewFromMap()functions inpkg/util/config/config.goChanges
TestValidate: Tests validation logic including:
TestNewFromMap: Tests config creation from map including:
TestMain: Sets
OPERATOR_NAMESPACEenvironment variable to avoidlog.Fatalwhen running tests outside a Kubernetes podTest plan
go test ./pkg/util/config/...)go test ./...)Disclosure: I used AI assistance (Claude) to help implement this change under my review and testing.
Closes #416