Switch to CRD-based config as the default#696
Closed
FxKu wants to merge 9 commits into
Closed
Conversation
FxKu
requested review from
CyberDem0n,
Jan-M,
RafiaSabih,
avaczi,
erthalion and
sdudoladov
as code owners
FxKu
force-pushed
the
crd-config-default
branch
from
eea6f88 to
7d3cc9b
Compare
FxKu
force-pushed
the
crd-config-default
branch
from
9fa3997 to
734a334
Compare
Contributor
|
Can we get this moving? If I can help? (It is just that I need to maintain a fork for the kustomize to work, and it would be awesome if this is upstream) danke! |
Contributor
Author
|
Closing this PR as it has to many conflicts and helm chart values file is already merged |
github-project-automation
Bot
moved this from WIP / currently reviewed
to Done
in Postgres Operator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With CRD validation for
OperatorConfigurationin place, this configuration option can be regarded superior to ConfigMap one.Also suggested by @pierreozoux in #693