fix(callback_role): support custom Kubernetes cluster domains#1201
Open
mdoulabi1 wants to merge 1 commit into
Open
fix(callback_role): support custom Kubernetes cluster domains#1201mdoulabi1 wants to merge 1 commit into
mdoulabi1 wants to merge 1 commit into
Conversation
Replace hardcoded cluster.local with KUBERNETES_SERVICE_HOST env var. Users can now set custom cluster domains like: - https://kubernetes.default.svc.cluster.bk1 - http://192.168.1.1:8443 Fully backwards compatible - defaults to previous behavior. Fixes: patroni could not patch pod labels on clusters with custom cluster domains. (cherry picked from commit 0b78ed2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The current callback role behavior assumes the default Kubernetes cluster domain. In environments that use a custom cluster domain, generated service or callback-related addresses do not resolve correctly, which breaks
callback role behavior.
This change updates the callback role logic to work with custom Kubernetes cluster domains instead of relying on the default DNS suffix.
Test