Skip to content

Spelling Updates Batch 3#4310

Merged
psiinon merged 4 commits into
zaproxy:mainfrom
kingthorin:spelling-batch3
Dec 29, 2022
Merged

Spelling Updates Batch 3#4310
psiinon merged 4 commits into
zaproxy:mainfrom
kingthorin:spelling-batch3

Conversation

@kingthorin

Copy link
Copy Markdown
Member

Cherry picked from: #3083 and rebased current.

@kingthorin

Copy link
Copy Markdown
Member Author

I'm not sure if we want to include the FuzzDB changes or not, they were also PR'd upstream as well but there's on-going challenges with that 🤷

@thc202

thc202 commented Dec 20, 2022

Copy link
Copy Markdown
Member

IMO revert, apply them when fixed upstream.

Comment on lines +9 to +10
P:001-HTT-PMT:HTTP Methods:15
> HTTP | Replacive Fuzzers
> HTTP | Replacing Fuzzers

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is duplicated in several add-ons, better move it into a common place and fix it once.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we want to do this? Move it to commonlib and make the other add-ons depend on that?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest reverting them for the time being and handle in follow up PR.

I'd prefer not introduce an unnecessary dependency, but I guess sooner or later they will have to depend on commonlib (fuzz will very soon because of the thread changes so…).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

* delay
* fuzzer
* payload
* payloads
* permission
* replacing
* tooltip

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* arbitrary
* demonstrate

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* apply
* constraints
* entries
* tries

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* output
* something's

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@kingthorin

Copy link
Copy Markdown
Member Author

Reverted jbrf changes.

@thc202

thc202 commented Dec 29, 2022

Copy link
Copy Markdown
Member

Thank you both!

@psiinon psiinon merged commit 02bcfc1 into zaproxy:main Dec 29, 2022
@kingthorin kingthorin deleted the spelling-batch3 branch December 29, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants