Include isssue references for xfailed tests.

Author: sharkinsspatial

virtualizarr/tests/test_readers/conftest.py

@@ -205,21 +205,21 @@ def skip_test_for_libhdf5_version():
     return libhdf5_version < Version("1.14")
 
 
-@pytest.fixture(params=["blosc_zlib"])
+@pytest.fixture(params=["blosc_zlib", ""])
 def filter_encoded_roundtrip_netcdf4_file(
     tmpdir, request, skip_test_for_libhdf5_version
 ):
     if skip_test_for_libhdf5_version:
         pytest.skip("Requires libhdf5 >= 1.14")
     ds = create_test_data(dim_sizes=(20, 80, 10))
+    encoding_config = {
+        "chunksizes": (20, 40),
+        "original_shape": ds.var2.shape,
+        "blosc_shuffle": 1,
+        "fletcher32": False,
+    }
     if "blosc" in request.param:
-        encoding_config = {
-            "compression": request.param,
-            "chunksizes": (20, 40),
-            "original_shape": ds.var2.shape,
-            "blosc_shuffle": 1,
-            "fletcher32": False,
-        }
+        encoding_config["compression"] = request.param
     #  Check on how handle scalar dim.
     ds = ds.drop_dims("dim3")
     ds["var2"].encoding.update(encoding_config)

virtualizarr/tests/test_readers/test_hdf_integration.py

@@ -3,50 +3,48 @@
 import xarray.testing as xrt
 
 import virtualizarr
-from virtualizarr.backend import FileType
 from virtualizarr.readers.hdf import HDFVirtualBackend
 from virtualizarr.tests import requires_kerchunk
 
 
 @requires_kerchunk
-@pytest.mark.parametrize("hdf_backend", [None, HDFVirtualBackend])
 class TestIntegration:
-    @pytest.mark.xfail(reason="0 time start is being interpreted as fillvalue")
+    @pytest.mark.xfail(
+        reason="0 time start is being interpreted as fillvalue see issues/280"
+    )
     def test_filters_h5netcdf_roundtrip(
-        self, tmpdir, filter_encoded_roundtrip_hdf5_file, hdf_backend
+        self, tmpdir, filter_encoded_roundtrip_hdf5_file, backend=HDFVirtualBackend
     ):
         ds = xr.open_dataset(filter_encoded_roundtrip_hdf5_file, decode_times=True)
         vds = virtualizarr.open_virtual_dataset(
             filter_encoded_roundtrip_hdf5_file,
             loadable_variables=["time"],
             cftime_variables=["time"],
-            backend=hdf_backend,
+            backend=HDFVirtualBackend,
         )
         kerchunk_file = f"{tmpdir}/kerchunk.json"
         vds.virtualize.to_kerchunk(kerchunk_file, format="json")
         roundtrip = xr.open_dataset(kerchunk_file, engine="kerchunk", decode_times=True)
         xrt.assert_allclose(ds, roundtrip)
 
-    @pytest.mark.xfail(reason="Coordinate issue affecting kerchunk and HDF reader.")
+    @pytest.mark.xfail(
+        reason="Coordinate issue affecting only hdf reader see pull/#260"
+    )
     def test_filters_netcdf4_roundtrip(
-        self, tmpdir, filter_encoded_roundtrip_netcdf4_file, hdf_backend
+        self, tmpdir, filter_encoded_roundtrip_netcdf4_file
     ):
         filepath = filter_encoded_roundtrip_netcdf4_file["filepath"]
         ds = xr.open_dataset(filepath)
-        vds = virtualizarr.open_virtual_dataset(
-            filepath, filetype=FileType("netcdf4"), backend=hdf_backend
-        )
+        vds = virtualizarr.open_virtual_dataset(filepath, backend=HDFVirtualBackend)
         kerchunk_file = f"{tmpdir}/kerchunk.json"
         vds.virtualize.to_kerchunk(kerchunk_file, format="json")
         roundtrip = xr.open_dataset(kerchunk_file, engine="kerchunk")
         xrt.assert_equal(ds, roundtrip)
 
-    def test_filter_and_cf_roundtrip(
-        self, tmpdir, filter_and_cf_roundtrip_hdf5_file, hdf_backend
-    ):
+    def test_filter_and_cf_roundtrip(self, tmpdir, filter_and_cf_roundtrip_hdf5_file):
         ds = xr.open_dataset(filter_and_cf_roundtrip_hdf5_file)
         vds = virtualizarr.open_virtual_dataset(
-            filter_and_cf_roundtrip_hdf5_file, backend=hdf_backend
+            filter_and_cf_roundtrip_hdf5_file, backend=HDFVirtualBackend
         )
         kerchunk_file = f"{tmpdir}/filter_cf_kerchunk.json"
         vds.virtualize.to_kerchunk(kerchunk_file, format="json")