Commit a2d7a13
Open existing groups when writing a DataTree with region/append_dim
virtual_datatree_to_icechunk unconditionally created each node's group
with Group.from_store, so forwarding region or append_dim (which require
the group and its arrays to already exist) always failed with
ContainsGroupError. Mirror the branch virtual_dataset_to_icechunk
already had: open the existing group for region/append_dim, create it
otherwise.
Removes the now-passing xfail on test_write_datatree_region, whose
stated reason (an xarray region limitation) was a misdiagnosis of this
ContainsGroupError.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>1 parent e1ebb4b commit a2d7a13
3 files changed
Lines changed: 9 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
12 | 15 | | |
13 | 16 | | |
14 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
996 | 996 | | |
997 | 997 | | |
998 | 998 | | |
999 | | - | |
1000 | | - | |
1001 | | - | |
1002 | 999 | | |
1003 | 1000 | | |
1004 | 1001 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
238 | 238 | | |
239 | 239 | | |
240 | 240 | | |
241 | | - | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
242 | 247 | | |
243 | 248 | | |
244 | 249 | | |
| |||
0 commit comments