fix: raise a clear error when concatenating along a scalar coord#1015
Open
maxrjones wants to merge 2 commits into
Open
fix: raise a clear error when concatenating along a scalar coord#1015maxrjones wants to merge 2 commits into
maxrjones wants to merge 2 commits into
Conversation
…d scalar coordinate
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
==========================================
+ Coverage 89.97% 90.16% +0.18%
==========================================
Files 36 36
Lines 2224 2236 +12
==========================================
+ Hits 2001 2016 +15
+ Misses 223 220 -3
🚀 New features to boost your workflow:
|
TomNicholas
requested changes
Jun 24, 2026
TomNicholas
left a comment
Member
There was a problem hiding this comment.
Thanks, let's de-claude the tests before merging.
TomNicholas
reviewed
Jun 24, 2026
| ) | ||
| xrt.assert_identical(combined_vds, expected_vds) | ||
|
|
||
| def test_nested_concat_dim_scalar_virtual_coord_raises( |
Member
There was a problem hiding this comment.
I think we should delete all the other tests from this PR except the first part of this one. Every other test here either tests a private internal, or tests a behaviour that should already be tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@hrodmn hit the obscure missing chunk manager error today, this time because xarray tried to load data when generating indexes for concatenating along a dimension that has scalar coordinates. This PR raises a clear error with informative guidance (load the variable).
This is a distinct from existing chunk manager issues so it doesn't close anything, but is related to #114.
Acceptance criteria:
docs/releases.md*.mdfile underdocs/api