Skip to content

Use ManifesStore to_virtual_variable directly in HDFVirtualBackend.#542

Merged
sharkinsspatial merged 31 commits intodevelopfrom
reader_manifeststore
Apr 21, 2025
Merged

Use ManifesStore to_virtual_variable directly in HDFVirtualBackend.#542
sharkinsspatial merged 31 commits intodevelopfrom
reader_manifeststore

Conversation

@sharkinsspatial
Copy link
Copy Markdown
Collaborator

@sharkinsspatial sharkinsspatial commented Apr 10, 2025

  • Closes #xxxx
  • Tests added
  • Tests passing
  • Full type hint coverage
  • Changes are documented in docs/releases.rst
  • New functions/methods are listed in api.rst
  • New functionality has documentation

@TomNicholas
Copy link
Copy Markdown
Member

@sharkinsspatial I think I've been refactoring the exact same bit of code locally 😅

@TomNicholas
Copy link
Copy Markdown
Member

Use this PR instead @sharkinsspatial

#543

@TomNicholas
Copy link
Copy Markdown
Member

Why is this diff now 1000 lines?

@sharkinsspatial
Copy link
Copy Markdown
Collaborator Author

🤦 Uff. I seemed to rebase something incorrectly here.

Comment thread virtualizarr/common.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.28%. Comparing base (fd2ccf3) to head (2ea03fa).
Report is 22 commits behind head on develop.

Files with missing lines Patch % Lines
virtualizarr/readers/hdf/hdf.py 85.71% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #542      +/-   ##
===========================================
- Coverage    87.67%   87.28%   -0.39%     
===========================================
  Files           31       32       +1     
  Lines         1890     2092     +202     
===========================================
+ Hits          1657     1826     +169     
- Misses         233      266      +33     
Files with missing lines Coverage Δ
virtualizarr/manifests/store.py 91.56% <100.00%> (+6.14%) ⬆️
virtualizarr/readers/hdf/hdf.py 94.25% <85.71%> (-0.68%) ⬇️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sharkinsspatial sharkinsspatial marked this pull request as ready for review April 19, 2025 18:08
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
Comment thread virtualizarr/readers/hdf/hdf.py
Comment thread virtualizarr/readers/hdf/hdf.py
Comment thread virtualizarr/readers/hdf/hdf.py Outdated
Comment thread virtualizarr/readers/hdf/hdf.py Outdated
Comment thread virtualizarr/readers/hdf/hdf.py
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
sharkinsspatial and others added 2 commits April 19, 2025 19:12
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
@sharkinsspatial sharkinsspatial merged commit d6b404d into develop Apr 21, 2025
10 checks passed
@sharkinsspatial sharkinsspatial deleted the reader_manifeststore branch April 21, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants