Use ManifesStore to_virtual_variable directly in HDFVirtualBackend.#542
Merged
sharkinsspatial merged 31 commits intodevelopfrom Apr 21, 2025
Merged
Use ManifesStore to_virtual_variable directly in HDFVirtualBackend.#542sharkinsspatial merged 31 commits intodevelopfrom
sharkinsspatial merged 31 commits intodevelopfrom
Conversation
Member
|
@sharkinsspatial I think I've been refactoring the exact same bit of code locally 😅 |
Member
|
Use this PR instead @sharkinsspatial |
0a7ad55 to
a18f6ee
Compare
Member
|
Why is this diff now 1000 lines? |
Collaborator
Author
|
🤦 Uff. I seemed to rebase something incorrectly here. |
a18f6ee to
3fd03e5
Compare
TomNicholas
reviewed
Apr 13, 2025
ed6079f to
ebca020
Compare
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #542 +/- ##
===========================================
- Coverage 87.67% 87.28% -0.39%
===========================================
Files 31 32 +1
Lines 1890 2092 +202
===========================================
+ Hits 1657 1826 +169
- Misses 233 266 +33
🚀 New features to boost your workflow:
|
maxrjones
reviewed
Apr 19, 2025
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
for more information, see https://pre-commit.ci
Co-authored-by: Max Jones <14077947+maxrjones@users.noreply.github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/releases.rstapi.rst