Skip to content

Refactor codebase to support a new simplified Parser->ManifestStore model. #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxrjones merged 122 commits into from
Jun 16, 2025

Apply suggestions from code review

6d753d9
Select commit
Loading
Failed to load commit list.
Merged

Refactor codebase to support a new simplified Parser->ManifestStore model. #601

Apply suggestions from code review
6d753d9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 16, 2025 in 0s

88.05% (target 75.00%)

View this Pull Request on Codecov

88.05% (target 75.00%)

Details

Codecov Report

Attention: Patch coverage is 87.82609% with 56 lines in your changes missing coverage. Please review.

Project coverage is 88.05%. Comparing base (639e8d4) to head (6d753d9).

Files with missing lines Patch % Lines
virtualizarr/parsers/tiff.py 0.00% 18 Missing ⚠️
virtualizarr/xarray.py 82.25% 11 Missing ⚠️
virtualizarr/parsers/hdf/hdf.py 95.27% 6 Missing ⚠️
virtualizarr/manifests/store.py 80.00% 4 Missing ⚠️
virtualizarr/parsers/kerchunk_parquet.py 90.90% 4 Missing ⚠️
virtualizarr/parsers/utils.py 72.72% 3 Missing ⚠️
virtualizarr/parsers/fits.py 88.88% 2 Missing ⚠️
virtualizarr/parsers/netcdf3.py 88.23% 2 Missing ⚠️
virtualizarr/translators/kerchunk.py 92.00% 2 Missing ⚠️
virtualizarr/parsers/dmrpp.py 97.87% 1 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #601      +/-   ##
===========================================
- Coverage    89.39%   88.05%   -1.35%     
===========================================
  Files           34       32       -2     
  Lines         1943     1783     -160     
===========================================
- Hits          1737     1570     -167     
- Misses         206      213       +7
Files with missing lines Coverage Δ
virtualizarr/__init__.py 77.77% <100.00%> (ø)
virtualizarr/parallel.py 84.37% <100.00%> (-15.63%) ⬇️
virtualizarr/parsers/__init__.py 100.00% <100.00%> (ø)
virtualizarr/parsers/hdf/filters.py 97.97% <ø> (ø)
virtualizarr/parsers/dmrpp.py 94.40% <97.87%> (ø)
virtualizarr/parsers/kerchunk_json.py 96.29% <96.29%> (ø)
virtualizarr/parsers/zarr.py 95.77% <94.44%> (ø)
virtualizarr/utils.py 67.21% <85.71%> (-7.48%) ⬇️
virtualizarr/parsers/fits.py 88.88% <88.88%> (ø)
virtualizarr/parsers/netcdf3.py 88.23% <88.23%> (ø)
... and 7 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov