-
Notifications
You must be signed in to change notification settings - Fork 63
Refactor codebase to support a new simplified Parser->ManifestStore model. #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
122 commits
Select commit
Hold shift + click to select a range
5bba81d
sketch kerchunk-based constructor method on ManifestStore
TomNicholas 0508fa1
sketch how FITS reader would use this constructor
TomNicholas ecb538c
tidy up imports
TomNicholas 5fb5c25
make new constructor a public method
TomNicholas cc7822e
refactor kerchunk module to create a ManifestStore instead of using x…
TomNicholas dece713
show how this changes the fits reader
TomNicholas fda8ce3
switch all kerchunk readers to use ManifestStore
TomNicholas c7aa584
fix double import
TomNicholas 4ca1027
change test to use ManifestStore
TomNicholas 6e7b2b2
Merge branch 'develop' into refactor-kerchunk-readers-to-use-Manifest…
TomNicholas 232f8b2
remove apparently uneeded list_dir function
TomNicholas 9526913
remove ManifestStore constructor
TomNicholas 38085ab
improve docstring
TomNicholas 53b466c
use function instead of method
TomNicholas 8e67aa5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 16a3510
Merge branch 'develop' into Refactor-kerchunk-readers-to-use-Manifest…
TomNicholas a19ca31
Merge branch 'refactor-kerchunk-readers-to-use-ManifestStore' of http…
TomNicholas 2337329
Initial steps for functional backends.
sharkinsspatial a5e009c
Use updated backend protocol.
sharkinsspatial 5bd8d02
Revert utils ReadableFile change.
sharkinsspatial f70240c
Use ObstoreReader util in hdf backend.
sharkinsspatial ef8d29b
Merge branch '547' into refactor/backends
sharkinsspatial 929dcd6
Intermediate updates for refactored kerchunk backend.
sharkinsspatial bd707d5
DMRPP reader updated to return ManifestStore.
sharkinsspatial 854e784
Update open_virtual_mfdataset to use ManifestStore open_virtual_mfdat…
sharkinsspatial 30c2550
Update Zarr backend to return ManifestStore.
sharkinsspatial 809ebfb
Typing updates for zarr backend obstore compatability.
sharkinsspatial d9d2500
Update test_xarray with new open_virtual_dataset signature.
sharkinsspatial 530778e
Use ManifestStore verification tests for HDF backend.
sharkinsspatial b121941
Update HDF backend integration tests for open_virtual_dataset signature.
sharkinsspatial f73d71e
Update FITS backend to use new backend signature.
sharkinsspatial 0d46797
Convert tiff and netcdf3 backends to new Manifeststore signature.
sharkinsspatial ded5ec1
Repo structural updates for all xarray functionality in single module.
sharkinsspatial 390710e
Align with new VirtualiZarr v2 API signatures.
sharkinsspatial aae10aa
Typing updates and fixes.
sharkinsspatial 19c721b
Remove legacy backend tests.
sharkinsspatial 009bce2
Use new Zarr v3 array fillvalue semantics.
sharkinsspatial a339650
Typing fix for fillValue casting.
sharkinsspatial d59acdc
Merge branch 'develop' into refactor/backends
sharkinsspatial 6abc757
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 61bc843
Include obstore as core dependency.
sharkinsspatial 9136efc
Use obstore dependency alias for other environments.
sharkinsspatial df92879
Temporarily skip lithops parallel tests.
sharkinsspatial 0d89b38
Broaden ignore statements for kerchunk translator.
sharkinsspatial 856f16f
Update minio test paths.
sharkinsspatial 7377185
Update ObstoreReader logic to handle local paths differently.
sharkinsspatial 1a8fe93
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 55b30c7
Fix s3 store construction for failing minio test.
sharkinsspatial 748ea73
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5d0b032
Re-enable lithops parallel tests.
sharkinsspatial 9be5f78
Temporarily disable lithops tests.
sharkinsspatial d9b6553
Remove legacy dmrpp loadable_variables comments.
sharkinsspatial b1f2b4c
Remove fsspec pin.
sharkinsspatial 1441b17
Use discrete parser for each open_virtual_dataset call.
sharkinsspatial 9e96977
Merge branch 'develop' into refactor/backends
sharkinsspatial 1b7ae5d
Check lithops failure with a single store.
sharkinsspatial a0bf35c
Fix incorrect parser invocation.
sharkinsspatial 6a16086
Make kerchunk parquet a stand alone parser.
sharkinsspatial e8d0979
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 817cf31
Don't check for parquet structure.
sharkinsspatial 2ff6b42
Pyproject.toml dependency updates.
sharkinsspatial 2570349
Remove all references to hdf5 parser dependencies.
sharkinsspatial 24dd28f
Remove errant space.
sharkinsspatial c497148
Change open_virtual_dataset module location to xarray in docs.
sharkinsspatial 987ae07
Temporarily xfail lithops exector tests.
sharkinsspatial 30bbecc
Unmark xpassing non_dimension_coordinate test.
sharkinsspatial 4afc1a9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9accf59
Remove default_object_store and support PrefixStore
maxrjones fcee85d
Update ObjectStoreRegistry usage in parsers to pass tests.
sharkinsspatial 30deeb0
Merge branch 'develop' into refactor/backends
sharkinsspatial e20f1ca
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a0b11f4
Use MemoryStore for non-existent file paths in test refs.
sharkinsspatial 86e4fac
Test kerchunk translator regression for variable attributes.
sharkinsspatial 7753850
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e07a2c7
Pass through drop_variables option to xarray.
sharkinsspatial a960f68
Remove separate obstore optional dependency.
sharkinsspatial 8185a3c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5e9db43
Rename KerchunkParser to KerchunkJSONParser.
sharkinsspatial 36088a5
Add docstring for Parser __call__ method.
sharkinsspatial 8b360ff
Use skip_variables naming for parsers rather than drop_variables.
sharkinsspatial 6b5243a
Add docstrings for public methods in parsers.
sharkinsspatial 8accc62
Refactor manifeststore_from_kerchunk_refs to return ManifestGroup.
sharkinsspatial d907472
Update ObjectstoreRegistry url parsing.
sharkinsspatial c54fd9c
Update ObjectstoreRegistry url doc string language.
sharkinsspatial a664fdc
Remove sorting for ObjectstoreRegistry prefix matching.
sharkinsspatial bd9ea6c
Apply suggestions from code review
maxrjones a2d4cfe
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 39186c2
Use removeprefix() rather than replace()
maxrjones cc84b6b
Apply suggested simplifications for HDF parser
maxrjones f374f73
Apply suggestions from code review
maxrjones f9d3f04
Use context managers
maxrjones 67d3f3f
Add Raises section
maxrjones 497918e
More context managers
maxrjones 9294606
Move imports
maxrjones f2d30d4
Move import
maxrjones fba6315
Address failing tests in test-py311 env
chuckwondo 922395e
Merge develop and resolve conflicts
chuckwondo 1e34558
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 08e6d0b
Merge branch 'develop' into refactor/backends
maxrjones fb9e036
Merge branch 'develop' into refactor/backends
maxrjones c071650
Fix typing errors and notes
chuckwondo 22c2438
Fix numpydoc-validation error
chuckwondo 0ec13aa
Format docstrings
chuckwondo ca117bb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0e7e4c2
Merge branch 'develop' into refactor/backends
maxrjones 2fc13ba
Remove duplicate LocalStore
maxrjones 171b6ac
Update virtualizarr/parsers/__init__.py
sharkinsspatial f77c215
Update virtualizarr/manifests/store.py
sharkinsspatial 12a95ca
Update virtualizarr/parsers/__init__.py
sharkinsspatial 523ae2c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f3e3b02
Remove json specification determination for kerchunk json parser.
sharkinsspatial 402eaf7
Update pyproject.toml
sharkinsspatial ebe1712
Update pyproject.toml
sharkinsspatial 95c5a60
Update virtualizarr/parsers/kerchunk_json.py
sharkinsspatial 3dbfc48
Update virtualizarr/parsers/tiff.py
sharkinsspatial 2b329d8
Update virtualizarr/parsers/zarr.py
sharkinsspatial 8df371a
Update pyproject.toml
sharkinsspatial c2f4ff3
Update pyproject.toml
sharkinsspatial f3ab4bf
Update virtualizarr/utils.py
sharkinsspatial ad084c4
Use format specific names for parser classes.
sharkinsspatial b7b1b08
Update virtualizarr/parsers/fits.py
maxrjones 6d753d9
Apply suggestions from code review
maxrjones File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.