Skip to content

Dmrpp migration#902

Draft
Mikejmnez wants to merge 13 commits intozarr-developers:mainfrom
Mikejmnez:dmrpp_migration
Draft

Dmrpp migration#902
Mikejmnez wants to merge 13 commits intozarr-developers:mainfrom
Mikejmnez:dmrpp_migration

Conversation

@Mikejmnez
Copy link
Copy Markdown
Contributor

@Mikejmnez Mikejmnez commented Mar 6, 2026

This DRAFT PR migrates the core of the dmrpp parser to pydap, integrating it for better support, while incorporating the latest contributions (for example #880). For example, the parser can reference external sources/path to individual chunks (no longer inheriting and assuming all chunks are within the file), parse inline (compressed) values, etc. Improvement of the dmrpp parser will continue close to the source, whilst aiming for interoperability with virtualizarr.

  • Closes pydap#417.
  • Tests added (mostly removed)
  • Tests passing (py311 and py312 environments)
  • Full type hint coverage
  • Changes are documented in docs/releases.rst
  • New functions/methods are listed in api.rst
  • New functionality has documentation

This is still draft, since I need to make a new official release of pydap to make these and update the project.toml to reflect the pydap release. Aside from that, all parser tests have been migrated to pydap (where they pass)

@betolink

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.43%. Comparing base (3c10c43) to head (0365302).

Files with missing lines Patch % Lines
virtualizarr/parsers/dmrpp.py 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
+ Coverage   89.29%   89.43%   +0.13%     
==========================================
  Files          33       33              
  Lines        2036     1902     -134     
==========================================
- Hits         1818     1701     -117     
+ Misses        218      201      -17     
Files with missing lines Coverage Δ
virtualizarr/parsers/dmrpp.py 82.81% <96.00%> (-3.05%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DMR++ references generation Reading byte ranges from archival files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants