-
Notifications
You must be signed in to change notification settings - Fork 65
Dmrpp migration #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mikejmnez
wants to merge
22
commits into
zarr-developers:main
Choose a base branch
from
Mikejmnez:dmrpp_migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dmrpp migration #902
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
3c4076f
remove migrated tests
Mikejmnez bd8d1e6
strip DMRParser class
Mikejmnez 05e4935
update DMRParser class to allow for on-the-fly dmrpps
Mikejmnez 7ef4b15
add pydap as optional dependency
Mikejmnez 278a3df
comment tests as these are migrated
Mikejmnez d01b22b
raise NotImplementError if inline values
Mikejmnez 421097b
install pydap from unreleased PR
Mikejmnez 161d831
rebase
Mikejmnez 0f5bf2f
rebase
Mikejmnez c04f127
rebase
Mikejmnez 1df2b87
fix mypy
Mikejmnez c6b11ff
skip test on macOS too
Mikejmnez 4f3763a
update how inline references are handled v1
Mikejmnez 8dccd22
update how inline references are handled v2
Mikejmnez cf838b7
add pydap to min-deps via `dev` - avoid min-deps ci/cd failure
Mikejmnez 9a85bfd
fix missing `,`
Mikejmnez c1fec29
add a separate isolated opt-dep entry for dmrpp
Mikejmnez 2d08220
update dmrpp migration - soft imports and code refactor
Mikejmnez d3c89e9
add dmrpp testing to py312 and py313
Mikejmnez cf4cefa
migrate dmrpp reading to pydap
Mikejmnez 86d8f62
rebase + update tests
Mikejmnez 75cab1c
document the change
Mikejmnez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a flag to update this before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - once this looks good on your end I will merge that PR, make a new pydap release (3.5.10), and declare pydap>=3.5.10 in here