fix: also require kerchunk for test_read_netcdf3#998
Merged
TomNicholas merged 1 commit intoMay 18, 2026
Merged
Conversation
NetCDF3Parser lazily imports kerchunk.netCDF3 inside __call__, but the test only had @requires_scipy. In environments that ship scipy without kerchunk (e.g. pixi min-deps once a transitive dep pulled in scipy) the test raised ModuleNotFoundError instead of being skipped.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #998 +/- ##
==========================================
+ Coverage 89.98% 90.04% +0.06%
==========================================
Files 33 33
Lines 2066 2089 +23
==========================================
+ Hits 1859 1881 +22
- Misses 207 208 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_read_netcdf3only had@requires_scipy, butNetCDF3Parser.__call__lazily importskerchunk.netCDF3. In any environment that has scipy without kerchunk, the test raisedModuleNotFoundErrorinstead of being skipped. Surfaced by themin-deps-buildjob on Dmrpp migration #902 once a transitive dep started pulling in scipy there. Adds@requires_kerchunk.Test plan
min-deps-buildpasses (scipy installed, kerchunk not — test should now skip).