Open
Conversation
✅ Deploy Preview for geozarrdemonstration4e8c9 canceled.
|
martham93
commented
Apr 10, 2026
Comment on lines
+23
to
+27
| "https://github.com/geo-embeddings/embeddings-zarr-convention/blob/main/schema.json" | ||
| ) | ||
| GEOEMB_SPEC_URL: Final[str] = ( | ||
| "https://github.com/geo-embeddings/embeddings-zarr-convention/blob/main/README.md" | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
I'm not actually sure what to do about these links (these don't feel like the right thing to use). The readme of convention references v1 but those don't actually exist yet, and those links 404
https://github.com/geo-embeddings/embeddings-zarr-convention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #12 adds validation support for geoembeddings
cc @geospatial-jeff in case you have time and want to weigh in