Skip to content

Commit fa92ee7

Browse files
CI: Fix Meson mixup between Conda and system Python headers (#839)
* use Conda Meson instead of system Meson Otherwise, Meson insists on getting Cython to include system Python headers which simply doesn't work: ----- Sanity check compile stderr: In file included from /usr/include/python3.10/Python.h:8, from sanity_check_for_cython.c:19: /usr/include/python3.10/pyconfig.h:9:12: fatal error: aarch64-linux-gnu/python3.10/pyconfig.h: No such file or directory 9 | # include <aarch64-linux-gnu/python3.10/pyconfig.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. ----- Also, avoid starting a new shell! * Create the `test` env * Different strategy: get rid of Conda altogther Conda was used to get GCC or Clang for compiling the C extensions. GitHub Actions runners come with C/C++ compilers pre-installed.
1 parent 1fdde70 commit fa92ee7

1 file changed

Lines changed: 11 additions & 33 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 11 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -27,25 +27,11 @@ jobs:
2727
submodules: recursive
2828
fetch-depth: 0 # required for version resolution
2929

30-
- name: Set up Conda
31-
uses: conda-incubator/setup-miniconda@v3.2.0
30+
- name: Set up Python
31+
uses: actions/setup-python@v6
3232
with:
33-
channels: conda-forge
34-
miniforge-version: latest
3533
python-version: ${{ matrix.python-version }}
36-
37-
- name: Install compilers
38-
run: conda install -y c-compiler cxx-compiler
39-
40-
- name: Install clang
41-
if: matrix.platform == 'macos-15-large'
42-
run: conda install -y 'clang>=12.0.1,<17'
43-
44-
- name: Show conda environment info
45-
run: |
46-
conda info
47-
conda config --show-sources
48-
conda list --show-channel-urls
34+
cache: 'pip'
4935

5036
- name: Install numcodecs
5137
run: |
@@ -93,15 +79,11 @@ jobs:
9379
submodules: recursive
9480
fetch-depth: 0
9581

96-
- name: Set up Conda
97-
uses: conda-incubator/setup-miniconda@v3.2.0
82+
- name: Set up Python
83+
uses: actions/setup-python@v6
9884
with:
99-
channels: conda-forge
100-
miniforge-version: latest
101-
python-version: "3.13"
102-
103-
- name: Install compilers
104-
run: conda install -y c-compiler cxx-compiler
85+
python-version: ${{ matrix.python-version }}
86+
cache: 'pip'
10587

10688
- name: Install numcodecs
10789
run: |
@@ -147,15 +129,11 @@ jobs:
147129
submodules: recursive
148130
fetch-depth: 0 # required for version resolution
149131

150-
- name: Set up Conda
151-
uses: conda-incubator/setup-miniconda@v3.2.0
132+
- name: Set up Python
133+
uses: actions/setup-python@v6
152134
with:
153-
channels: conda-forge
154-
miniforge-version: latest
155-
python-version: "3.13"
156-
157-
- name: Install compilers
158-
run: conda install -y c-compiler cxx-compiler
135+
python-version: ${{ matrix.python-version }}
136+
cache: 'pip'
159137

160138
- name: Install numcodecs and Zarr
161139
run: |

0 commit comments

Comments
 (0)