end index validation in MemoryStore

brokkoli71 · brokkoli71 · commit 135ca6d4ba10 · 2025-12-05T11:58:42.000+01:00
diff --git a/src/main/java/dev/zarr/zarrjava/store/MemoryStore.java b/src/main/java/dev/zarr/zarrjava/store/MemoryStore.java
@@ -44,7 +44,7 @@ public ByteBuffer get(String[] keys, long start, long end) {
     byte[] bytes = map.get(resolveKeys(keys));
     if (bytes == null) return null;
     if (end < 0) end = bytes.length;
-    if (end > Integer.MAX_VALUE) throw new RuntimeException("TODO"); //TODO
+    if (end > Integer.MAX_VALUE) throw new IllegalArgumentException("End index too large");
     return ByteBuffer.wrap(bytes, (int) start, (int) end);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ public ByteBuffer get(String[] keys, long start, long end) {`
`44`	`44`	`byte[] bytes = map.get(resolveKeys(keys));`
`45`	`45`	`if (bytes == null) return null;`
`46`	`46`	`if (end < 0) end = bytes.length;`
`47`		`- if (end > Integer.MAX_VALUE) throw new RuntimeException("TODO"); //TODO`
	`47`	`+ if (end > Integer.MAX_VALUE) throw new IllegalArgumentException("End index too large");`
`48`	`48`	`return ByteBuffer.wrap(bytes, (int) start, (int) end);`
`49`	`49`	`}`
`50`	`50`