remove detectDimensionSeparator

Author: brokkoli71

src/main/java/dev/zarr/zarrjava/v2/Array.java

@@ -60,27 +60,6 @@ public static Array open(StoreHandle storeHandle) throws IOException, ZarrExcept
                     Utils.toArray(storeHandle.resolve(ZATTRS).readNonNull()),
                     Attributes.class
             );
-        
-        // Auto-detect dimension separator if not specified and array has multiple dimensions
-        if (metadata.dimensionSeparator == null && metadata.shape.length > 1) {
-            Separator detectedSeparator = detectDimensionSeparator(storeHandle, metadata.chunks);
-            if (detectedSeparator != null) {
-                // Create a new metadata instance with the detected separator
-                metadata = new ArrayMetadata(
-                    metadata.zarrFormat,
-                    metadata.shape,
-                    metadata.chunks,
-                    metadata.dataType,
-                    metadata.parsedFillValue,
-                    metadata.order,
-                    metadata.filters,
-                    metadata.compressor,
-                    detectedSeparator,
-                    metadata.attributes
-                );
-            }
-        }
-        
         return new Array(
                 storeHandle,
                 metadata
@@ -272,70 +251,6 @@ public Array updateAttributes(Function<Attributes, Attributes> attributeMapper)
         return setAttributes(attributeMapper.apply(metadata.attributes));
     }
 
-    /**
-     * Detects dimension separator from existing chunk files in the store.
-     * Similar to JZarr's ZarrArray::findNestedChunks method.
-     * 
-     * @param storeHandle the store containing the array
-     * @param chunks the chunk shape
-     * @return the detected separator (SLASH or DOT), or null if detection fails
-     */
-    @Nullable
-    private static Separator detectDimensionSeparator(StoreHandle storeHandle, int[] chunks) {
-        // Only attempt detection if store supports listing
-        if (!(storeHandle.store instanceof Store.ListableStore)) {
-            return null;
-        }
-        
-        try {
-            // List all files in the array directory, excluding metadata files (.zarray, .zattrs, .zgroup)
-            String[] chunkFiles = storeHandle.list()
-                .filter(key -> !key.startsWith(".z"))
-                .toArray(String[]::new);
-            
-            if (chunkFiles.length == 0) {
-                // No chunks exist yet, cannot detect
-                return null;
-            }
-            
-            // Build regex pattern to match nested chunks (SLASH separator)
-            // Pattern: \d+/\d+/... for multi-dimensional arrays
-            StringBuilder nestedPattern = new StringBuilder("\\d+");
-            for (int i = 1; i < chunks.length; i++) {
-                nestedPattern.append("/\\d+");
-            }
-            String nestedRegex = nestedPattern.toString();
-            
-            // Check if any chunk file matches the nested pattern
-            for (String chunkFile : chunkFiles) {
-                if (chunkFile.matches(nestedRegex)) {
-                    return Separator.SLASH;
-                }
-            }
-            
-            // Build regex pattern to match flat chunks (DOT separator)
-            // Pattern: \d+.\d+.... for multi-dimensional arrays
-            StringBuilder flatPattern = new StringBuilder("\\d+");
-            for (int i = 1; i < chunks.length; i++) {
-                flatPattern.append("\\.\\d+");
-            }
-            String flatRegex = flatPattern.toString();
-            
-            // Check if any chunk file matches the flat pattern
-            for (String chunkFile : chunkFiles) {
-                if (chunkFile.matches(flatRegex)) {
-                    return Separator.DOT;
-                }
-            }
-            
-            // Could not detect separator from existing chunks
-            return null;
-        } catch (Exception e) {
-            // If listing fails, return null
-            return null;
-        }
-    }
-
     @Override
     public String toString() {
         return String.format("<v2.Array {%s} (%s) %s>", storeHandle,

src/test/java/dev/zarr/zarrjava/ZarrV2Test.java

@@ -453,68 +453,4 @@ public void testDefaultChunkShape() throws IOException, ZarrException {
         Assertions.assertTrue(mixedArray.metadata().chunks[2] > 0);
         Assertions.assertTrue(mixedArray.metadata().chunks[2] <= 2048);
     }
-
-    @Test
-    public void testDimensionSeparatorAutoDetection() throws IOException, ZarrException {
-        // Test with SLASH separator
-        StoreHandle slashStoreHandle = new FilesystemStore(TESTOUTPUT).resolve("v2_separator_detection_slash");
-        Array slashArray = Array.create(
-                slashStoreHandle,
-                Array.metadataBuilder()
-                        .withShape(10, 10)
-                        .withDataType(DataType.UINT8)
-                        .withChunks(5, 5)
-                        .withDimensionSeparator(dev.zarr.zarrjava.core.chunkkeyencoding.Separator.SLASH)
-                        .build()
-        );
-        
-        // Write some data to create chunk files
-        slashArray.write(new long[]{0, 0}, ucar.ma2.Array.factory(ucar.ma2.DataType.UBYTE, new int[]{5, 5}));
-        
-        // Now open without specifying separator - it should auto-detect SLASH
-        Array reopenedSlashArray = Array.open(slashStoreHandle);
-        Assertions.assertEquals(dev.zarr.zarrjava.core.chunkkeyencoding.Separator.SLASH, 
-                               reopenedSlashArray.metadata().dimensionSeparator);
-
-        // Test with DOT separator
-        StoreHandle dotStoreHandle = new FilesystemStore(TESTOUTPUT).resolve("v2_separator_detection_dot");
-        Array dotArray = Array.create(
-                dotStoreHandle,
-                Array.metadataBuilder()
-                        .withShape(10, 10)
-                        .withDataType(DataType.UINT8)
-                        .withChunks(5, 5)
-                        .withDimensionSeparator(dev.zarr.zarrjava.core.chunkkeyencoding.Separator.DOT)
-                        .build()
-        );
-        
-        // Write some data to create chunk files
-        dotArray.write(new long[]{0, 0}, ucar.ma2.Array.factory(ucar.ma2.DataType.UBYTE, new int[]{5, 5}));
-        
-        // Now open without specifying separator - it should auto-detect DOT
-        Array reopenedDotArray = Array.open(dotStoreHandle);
-        Assertions.assertEquals(dev.zarr.zarrjava.core.chunkkeyencoding.Separator.DOT, 
-                               reopenedDotArray.metadata().dimensionSeparator);
-    }
-
-    @Test
-    public void testDimensionSeparatorDefaultFallback() throws IOException, ZarrException {
-        // Test that when no chunks exist, the separator defaults to DOT (as per ArrayMetadata.chunkKeyEncoding())
-        StoreHandle emptyStoreHandle = new FilesystemStore(TESTOUTPUT).resolve("v2_separator_detection_empty");
-        Array emptyArray = Array.create(
-                emptyStoreHandle,
-                Array.metadataBuilder()
-                        .withShape(10, 10)
-                        .withDataType(DataType.UINT8)
-                        .withChunks(5, 5)
-                        .build()
-        );
-        
-        // Open without writing any chunks
-        Array reopenedEmptyArray = Array.open(emptyStoreHandle);
-        // Should use default DOT separator from ArrayMetadata.chunkKeyEncoding()
-        // When dimensionSeparator is null, chunkKeyEncoding() defaults to DOT
-        Assertions.assertEquals(dev.zarr.zarrjava.core.chunkkeyencoding.Separator.DOT,
-                               reopenedEmptyArray.metadata().chunkKeyEncoding().separator);
-    }
 }