s3 tests opt-in instead of opt-out

Author: brokkoli71

.github/workflows/ci.yml

@@ -59,10 +59,9 @@ jobs:
           MAVEN_OPTS: "-Xmx6g"
         run: |
           if [ "${{ matrix.os }}" == "ubuntu-latest" ]; then
-            mvn --no-transfer-progress test -DargLine="-Xmx6g"
+            mvn --no-transfer-progress test -DargLine="-Xmx6g" -DrunS3Tests=true
           else
-            # Skip S3 tests on Windows/macOS where the service isn't running (labeled with @Tag("s3"))
-            mvn --no-transfer-progress test -DargLine="-Xmx6g" -DexcludedGroups="s3"
+            mvn --no-transfer-progress test -DargLine="-Xmx6g"
           fi
       - name: Assemble JAR
         run: mvn package -DskipTests

src/test/java/dev/zarr/zarrjava/store/S3StoreTest.java

@@ -3,8 +3,8 @@
 import dev.zarr.zarrjava.ZarrException;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeAll;
-import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.condition.EnabledIfSystemProperty;
 import software.amazon.awssdk.auth.credentials.AwsBasicCredentials;
 import software.amazon.awssdk.auth.credentials.StaticCredentialsProvider;
 import software.amazon.awssdk.core.sync.RequestBody;
@@ -30,14 +30,15 @@
  * docker run -p 9090:9090 -p 9191:9191 -e "initialBuckets=zarr-test-bucket" adobe/s3mock:3.11.0
  * </pre>
  */
-@Tag("s3")
+@EnabledIfSystemProperty(named = "runS3Tests", matches = "true")
 public class S3StoreTest extends WritableStoreTest {
 
     String s3Endpoint = "http://localhost:9090";
     String bucketName = "zarr-test-bucket";
     S3Client s3Client;
     String testDataKey = "testData";
     S3Store s3Store;
+
     @BeforeAll
     void setUpS3Client() throws ZarrException, IOException {
         s3Client = S3Client.builder()

src/test/java/dev/zarr/zarrjava/store/StoreTest.java

@@ -97,9 +97,9 @@ public void testGetWithStartEnd() {
         buffer.get(actualBytes, 0, 10);
         Assertions.assertArrayEquals(expectedBytes, actualBytes);
 
-        buffer = storeHandle.read(size-10);
+        buffer = storeHandle.read(size - 10);
         Assertions.assertEquals(10, buffer.remaining());
-        fullBuffer.position((int)(size-10));
+        fullBuffer.position((int) (size - 10));
         fullBuffer.get(expectedBytes, 0, 10);
         buffer.get(actualBytes, 0, 10);
         Assertions.assertArrayEquals(expectedBytes, actualBytes);