use Any to model input / output types of numcodec protocol

Author: d-v-b

src/zarr/abc/numcodec.py

@@ -1,8 +1,6 @@
-from typing import Self, TypeGuard
+from typing import Any, Self, TypeGuard
 
-from typing_extensions import Buffer, Protocol
-
-from zarr.abc.codec import CodecJSON_V2
+from typing_extensions import Protocol
 
 
 class Numcodec(Protocol):
@@ -12,14 +10,14 @@ class Numcodec(Protocol):
 
     codec_id: str
 
-    def encode(self, buf: Buffer) -> Buffer: ...
+    def encode(self, buf: Any) -> Any: ...
 
-    def decode(self, buf: Buffer, out: Buffer | None = None) -> Buffer: ...
+    def decode(self, buf: Any, out: Any | None = None) -> Any: ...
 
-    def get_config(self) -> CodecJSON_V2[str]: ...
+    def get_config(self) -> Any: ...
 
     @classmethod
-    def from_config(cls, config: CodecJSON_V2[str]) -> Self: ...
+    def from_config(cls, config: Any) -> Self: ...
 
 
 def _is_numcodec_cls(obj: object) -> TypeGuard[type[Numcodec]]:

src/zarr/codecs/_v2.py

@@ -31,9 +31,9 @@ async def _decode_single(
         cdata = chunk_bytes.as_array_like()
         # decompress
         if self.compressor:
-            chunk = await asyncio.to_thread(self.compressor.decode, cdata)  # type: ignore[arg-type]
+            chunk = await asyncio.to_thread(self.compressor.decode, cdata)
         else:
-            chunk = cdata  # type: ignore[assignment]
+            chunk = cdata
 
         # apply filters
         if self.filters:
@@ -54,7 +54,7 @@ async def _decode_single(
                 # is an object array. In this case, we need to convert the object
                 # array to the correct dtype.
 
-                chunk = np.array(chunk).astype(chunk_spec.dtype.to_native_dtype())  # type: ignore[assignment]
+                chunk = np.array(chunk).astype(chunk_spec.dtype.to_native_dtype())
 
         elif chunk.dtype != object:
             # If we end up here, someone must have hacked around with the filters.
@@ -83,18 +83,16 @@ async def _encode_single(
         # apply filters
         if self.filters:
             for f in self.filters:
-                chunk = await asyncio.to_thread(f.encode, chunk)  # type: ignore[arg-type]
-
+                chunk = await asyncio.to_thread(f.encode, chunk)
         # check object encoding
         if ensure_ndarray_like(chunk).dtype == object:
             raise RuntimeError("cannot write object array without object codec")
 
         # compress
         if self.compressor:
-            cdata = await asyncio.to_thread(self.compressor.encode, chunk)  # type: ignore[arg-type]
+            cdata = await asyncio.to_thread(self.compressor.encode, chunk)
         else:
-            cdata = chunk  # type: ignore[assignment]
-
+            cdata = chunk
         cdata = ensure_bytes(cdata)
         return chunk_spec.prototype.buffer.from_bytes(cdata)
 

src/zarr/core/array.py

@@ -4849,12 +4849,12 @@ def _parse_chunk_encoding_v2(
             if _compressor is None:
                 object_codec_id = None
             else:
-                object_codec_id = get_object_codec_id((_compressor.get_config(),))  # type: ignore[arg-type]
+                object_codec_id = get_object_codec_id((_compressor.get_config(),))
         else:
             object_codec_id = get_object_codec_id(
                 (
-                    *[f.get_config() for f in _filters],  # type: ignore[arg-type]
-                    _compressor.get_config() if _compressor is not None else None,  # type: ignore[arg-type]
+                    *[f.get_config() for f in _filters],
+                    _compressor.get_config() if _compressor is not None else None,
                 )
             )
         if object_codec_id is None:

src/zarr/core/metadata/v2.py

@@ -200,8 +200,8 @@ def to_dict(self) -> dict[str, JSON]:
             codec_config = zarray_dict["compressor"].get_config()
             # Hotfix for https://github.com/zarr-developers/zarr-python/issues/2647
             if codec_config["id"] == "zstd" and not codec_config.get("checksum", False):
-                codec_config.pop("checksum")  # type: ignore[typeddict-item]
-            zarray_dict["compressor"] = codec_config  # type: ignore[assignment]
+                codec_config.pop("checksum")
+            zarray_dict["compressor"] = codec_config
 
         if zarray_dict["filters"] is not None:
             raw_filters = zarray_dict["filters"]
@@ -215,7 +215,7 @@ def to_dict(self) -> dict[str, JSON]:
                     new_filters.append(f.get_config())
                 else:
                     new_filters.append(f)
-            zarray_dict["filters"] = new_filters  # type: ignore[assignment]
+            zarray_dict["filters"] = new_filters
 
         # serialize the fill value after dtype-specific JSON encoding
         if self.fill_value is not None: