refactor: more cleanup

Author: ilan-gold

src/zarr/codecs/sharding.py

@@ -574,7 +574,7 @@ async def _encode_single(
                 chunk_grid=RegularChunkGrid(chunk_shape=chunk_shape),
             )
         )
-        shard_builder = dict.fromkeys(np.array(list(np.ndindex(chunks_per_shard))))
+        shard_builder = dict.fromkeys(self._subchunk_order_iter(chunks_per_shard, "lexicographic"))
 
         await self.codec_pipeline.write(
             [

tests/test_codecs/test_sharding.py

@@ -649,7 +649,6 @@ async def test_unordered_can_be_seeded() -> None:
             subchunk_write_order="unordered",
             rng=np.random.default_rng(seed=seed),
         )
-        # The physical write order is recovered by sorting coordinates by start offset.
         orders.append(await stored_data_and_get_order(codec, chunks_per_shard))
     assert all(orders[0] == o for o in orders)