Enforce ruff/flake8-annotations rules (ANN) (#2264)

* Apply ruff/flake8-annotations rule ANN204

ANN204 Missing return type annotation for special method `__init__`

* Apply ruff/flake8-annotations rule ANN201

ANN201 Missing return type annotation for public function `basic_indices`

* Enforce ruff/flake8-annotations rules (ANN)

Disable lots of rules for now, especially in tests.

Author: DimitriPapadopoulos

pyproject.toml

@@ -206,6 +206,7 @@ extend-exclude = [
 
 [tool.ruff.lint]
 extend-select = [
+    "ANN", # flake8-annotations
     "B",   # flake8-bugbear
     "C4",  # flake8-comprehensions
     "FLY", # flynt
@@ -222,6 +223,10 @@ extend-select = [
     "UP",  # pyupgrade
 ]
 ignore = [
+    "ANN003",
+    "ANN101",
+    "ANN102",
+    "ANN401",
     "PT004",  # deprecated
     "PT011",  # TODO: apply this rule
     "PT012",  # TODO: apply this rule
@@ -247,6 +252,9 @@ ignore = [
     "ISC002",
 ]
 
+[tool.ruff.lint.extend-per-file-ignores]
+"tests/**" = ["ANN001", "ANN201"]
+
 [tool.mypy]
 python_version = "3.11"
 ignore_missing_imports = true

src/zarr/store/logging.py

@@ -24,7 +24,7 @@ def __init__(
         store: Store,
         log_level: str = "DEBUG",
         log_handler: logging.Handler | None = None,
-    ):
+    ) -> None:
         self._store = store
         self.counter = defaultdict(int)
 

src/zarr/testing/strategies.py

@@ -158,7 +158,7 @@ def is_negative_slice(idx: Any) -> bool:
 
 
 @st.composite  # type: ignore[misc]
-def basic_indices(draw: st.DrawFn, *, shape: tuple[int], **kwargs):  # type: ignore[no-untyped-def]
+def basic_indices(draw: st.DrawFn, *, shape: tuple[int], **kwargs) -> Any:  # type: ignore[no-untyped-def]
     """Basic indices without unsupported negative slices."""
     return draw(
         npst.basic_indices(shape=shape, **kwargs).filter(