prune dead code, make protocols useful

Author: d-v-b

src/zarr/__init__.py

@@ -37,7 +37,6 @@
 from zarr.core.array import Array, AsyncArray
 from zarr.core.config import config
 from zarr.core.group import AsyncGroup, Group
-from zarr.experimental.sync_codecs import SyncCodecPipeline  # noqa: F401 (backwards compat)
 
 # in case setuptools scm screw up and find version to be 0.0.0
 assert not __version__.startswith("0.0.0")

src/zarr/core/array.py

@@ -25,6 +25,7 @@
 import zarr
 from zarr.abc.codec import ArrayArrayCodec, ArrayBytesCodec, BytesBytesCodec, Codec
 from zarr.abc.numcodec import Numcodec, _is_numcodec
+from zarr.abc.store import SyncByteGetter
 from zarr.codecs._v2 import V2Codec
 from zarr.codecs.bytes import BytesCodec
 from zarr.codecs.vlen_utf8 import VLenBytesCodec, VLenUTF8Codec
@@ -1982,8 +1983,9 @@ def _can_use_sync_path(self) -> bool:
            implement ``SupportsSyncCodec``). This is True for
            BatchedCodecPipeline when all codecs support sync.
 
-        2. The store supports synchronous operations (has ``get_sync``).
-           MemoryStore and LocalStore provide this; remote stores do not.
+        2. The store supports synchronous operations (implements
+           ``SyncByteGetter``). MemoryStore and LocalStore provide this;
+           remote stores do not.
 
         When both hold, the selection methods below call
         _get_selection_sync / _set_selection_sync directly, running the
@@ -1993,7 +1995,7 @@ def _can_use_sync_path(self) -> bool:
         """
         pipeline = self.async_array.codec_pipeline
         store = self.async_array.store_path.store
-        return getattr(pipeline, "supports_sync_io", False) and hasattr(store, "get_sync")
+        return getattr(pipeline, "supports_sync_io", False) and isinstance(store, SyncByteGetter)
 
     @classmethod
     @deprecated("Use zarr.create_array instead.", category=ZarrDeprecationWarning)
@@ -3088,8 +3090,8 @@ def get_basic_selection(
                 prototype=prototype,
             )
         # Fallback: submit the async coroutine to the background event loop
-        # thread via sync(). Used for remote stores, sharded arrays, or when
-        # SyncCodecPipeline is not active.
+        # thread via sync(). Used for remote stores or when the sync bypass
+        # is not active.
         return sync(
             self.async_array._get_selection(
                 indexer,

src/zarr/experimental/sync_codecs.py

@@ -297,18 +297,9 @@ def test_supports_sync_io(self) -> None:
         pipeline = BatchedCodecPipeline.from_codecs([BytesCodec(), GzipCodec(level=1)])
         assert pipeline.supports_sync_io
 
-    def test_config_switch_to_sync_pipeline_compat(self) -> None:
-        """Verify backwards compat: SyncCodecPipeline config path still works."""
-        from zarr.experimental.sync_codecs import SyncCodecPipeline
-
-        zarr.config.set({"codec_pipeline.path": "zarr.experimental.sync_codecs.SyncCodecPipeline"})
-        try:
-            store = MemoryStore()
-            arr = zarr.create_array(store, shape=(10,), dtype="float64")
-            assert isinstance(arr.async_array.codec_pipeline, SyncCodecPipeline)
-            # SyncCodecPipeline is-a BatchedCodecPipeline
-            assert isinstance(arr.async_array.codec_pipeline, BatchedCodecPipeline)
-        finally:
-            zarr.config.set(
-                {"codec_pipeline.path": "zarr.core.codec_pipeline.BatchedCodecPipeline"}
-            )
+    def test_supports_sync_io_default(self) -> None:
+        """Default BatchedCodecPipeline is the sync pipeline — no config switch needed."""
+        store = MemoryStore()
+        arr = zarr.create_array(store, shape=(10,), dtype="float64")
+        assert isinstance(arr.async_array.codec_pipeline, BatchedCodecPipeline)
+        assert arr.async_array.codec_pipeline.supports_sync_io