Experiment if we can remove the slow_wasm option now

Author: agriyakhetarpal

pyproject.toml

@@ -454,7 +454,6 @@ markers = [
     "asyncio: mark test as asyncio test",
     "gpu: mark a test as requiring CuPy and GPU",
     "slow_hypothesis: slow hypothesis tests",
-    "slow_wasm: slow tests in Pyodide/WASM",
 ]
 
 [tool.repo-review]

tests/conftest.py

@@ -283,30 +283,17 @@ def pytest_addoption(parser: Any) -> None:
         default=False,
         help="run slow hypothesis tests",
     )
-    parser.addoption(
-        "--run-slow-wasm",
-        action="store_true",
-        default=False,
-        help="run slow tests only applicable to WASM",
-    )
 
 
 def pytest_collection_modifyitems(config: Any, items: Any) -> None:
     if config.getoption("--run-slow-hypothesis"):
         return
-    if config.getoption("--run-slow-wasm") and IS_WASM:
-        return
 
     skip_slow_hyp = pytest.mark.skip(reason="need --run-slow-hypothesis option to run")
-    skip_slow_wasm = pytest.mark.skip(
-        reason="need --run-slow-wasm option to run in WASM, or not running in WASM"
-    )
 
     for item in items:
         if "slow_hypothesis" in item.keywords:
             item.add_marker(skip_slow_hyp)
-        if "slow_wasm" in item.keywords and IS_WASM:
-            item.add_marker(skip_slow_wasm)
 
 
 settings.register_profile(

tests/test_indexing.py

@@ -767,7 +767,6 @@ def _test_get_orthogonal_selection_3d(
         _test_get_orthogonal_selection(a, z, selection)
 
 
-@pytest.mark.slow_wasm
 def test_get_orthogonal_selection_3d(store: StorePath) -> None:
     # setup
     a = np.arange(32400, dtype=int).reshape(120, 30, 9)
@@ -825,7 +824,6 @@ def _test_set_orthogonal_selection(
         assert_array_equal(a, z[:])
 
 
-@pytest.mark.slow_wasm
 def test_set_orthogonal_selection_1d(store: StorePath) -> None:
     # setup
     v = np.arange(550, dtype=int)
@@ -868,7 +866,6 @@ def test_set_item_1d_last_two_chunks(store: StorePath):
     np.testing.assert_equal(z["zoo"][()], np.array(1))
 
 
-@pytest.mark.slow_wasm
 def _test_set_orthogonal_selection_2d(
     v: npt.NDArray[np.int_],
     a: npt.NDArray[np.int_],
@@ -889,7 +886,6 @@ def _test_set_orthogonal_selection_2d(
         _test_set_orthogonal_selection(v, a, z, selection)
 
 
-@pytest.mark.slow_wasm
 def test_set_orthogonal_selection_2d(store: StorePath) -> None:
     # setup
     v = np.arange(5400, dtype=int).reshape(600, 9)
@@ -948,7 +944,6 @@ def _test_set_orthogonal_selection_3d(
         _test_set_orthogonal_selection(v, a, z, selection)
 
 
-@pytest.mark.slow_wasm
 def test_set_orthogonal_selection_3d(store: StorePath) -> None:
     # setup
     v = np.arange(32400, dtype=int).reshape(120, 30, 9)
@@ -1160,7 +1155,6 @@ def test_set_coordinate_selection_1d(store: StorePath) -> None:
             z.vindex[selection] = 42  # type:ignore[index]
 
 
-@pytest.mark.slow_wasm
 def test_set_coordinate_selection_2d(store: StorePath) -> None:
     # setup
     v = np.arange(5400, dtype=int).reshape(600, 9)
@@ -1344,7 +1338,6 @@ def _test_set_block_selection(
         assert_array_equal(a, z[:])
 
 
-@pytest.mark.slow_wasm
 def test_set_block_selection_1d(store: StorePath) -> None:
     # setup
     v = np.arange(1050, dtype=int)
@@ -1363,7 +1356,6 @@ def test_set_block_selection_1d(store: StorePath) -> None:
             z.blocks[selection_bad] = 42  # type:ignore[index]
 
 
-@pytest.mark.slow_wasm
 def test_set_block_selection_2d(store: StorePath) -> None:
     # setup
     v = np.arange(10000, dtype=int).reshape(1000, 10)

tests/test_properties.py

@@ -247,7 +247,6 @@ async def test_vindex(data: st.DataObject) -> None:
     # note: async vindex setitem not yet implemented
 
 
-@pytest.mark.slow_wasm
 @given(store=stores, meta=array_metadata())  # type: ignore[misc]
 @pytest.mark.filterwarnings("ignore::zarr.core.dtype.common.UnstableSpecificationWarning")
 async def test_roundtrip_array_metadata_from_store(