move conversion functions into public api

K-Meech · K-Meech · commit 42aa7dbde52a · 2025-08-01T13:16:45.000+01:00
diff --git a/pyproject.toml b/pyproject.toml
@@ -115,7 +115,7 @@ docs = [
 ]
 
 [project.scripts]
-zarr = "zarr.core.metadata.converter.cli:app"
+zarr = "zarr._cli.cli:app"
 
 
 [project.urls]
diff --git a/src/zarr/_cli/__init__.py b/src/zarr/_cli/__init__.py
diff --git a/src/zarr/_cli/cli.py b/src/zarr/_cli/cli.py
@@ -4,7 +4,7 @@
 
 import typer
 
-import zarr.core.metadata.converter.migrate_to_v3 as migrate_metadata
+import zarr.metadata.migrate_v3 as migrate_metadata
 from zarr.core.sync import sync
 from zarr.storage._common import make_store
 
@@ -107,6 +107,7 @@ def migrate(
         output_zarr_store = sync(make_store(output_store, mode="w-"))
         write_store = output_zarr_store
     else:
+        output_zarr_store = None
         write_store = input_zarr_store
 
     if overwrite:
diff --git a/src/zarr/metadata/__init__.py b/src/zarr/metadata/__init__.py
@@ -0,0 +1,3 @@
+from zarr.metadata.migrate_v3 import migrate_to_v3, migrate_v2_to_v3, remove_metadata
+
+__all__ = ["migrate_to_v3", "migrate_v2_to_v3", "remove_metadata"]
diff --git a/src/zarr/metadata/migrate_v3.py b/src/zarr/metadata/migrate_v3.py
diff --git a/tests/test_cli/test_migrate_v3.py b/tests/test_cli/test_migrate_v3.py
@@ -27,9 +27,7 @@
 typer_testing = pytest.importorskip(
     "typer.testing", reason="optional cli dependencies aren't installed"
 )
-cli = pytest.importorskip(
-    "zarr.core.metadata.converter.cli", reason="optional cli dependencies aren't installed"
-)
+cli = pytest.importorskip("zarr._cli.cli", reason="optional cli dependencies aren't installed")
 
 runner = typer_testing.CliRunner()
 

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ docs = [`
`115`	`115`	`]`
`116`	`116`
`117`	`117`	`[project.scripts]`
`118`		`-zarr = "zarr.core.metadata.converter.cli:app"`
	`118`	`+zarr = "zarr._cli.cli:app"`
`119`	`119`
`120`	`120`
`121`	`121`	`[project.urls]`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+from zarr.metadata.migrate_v3 import migrate_to_v3, migrate_v2_to_v3, remove_metadata`
	`2`	`+`
	`3`	`+__all__ = ["migrate_to_v3", "migrate_v2_to_v3", "remove_metadata"]`
Original file line number	Diff line number	Diff line change
`@@ -27,9 +27,7 @@`
`27`	`27`	`typer_testing = pytest.importorskip(`
`28`	`28`	`"typer.testing", reason="optional cli dependencies aren't installed"`
`29`	`29`	`)`
`30`		`-cli = pytest.importorskip(`
`31`		`- "zarr.core.metadata.converter.cli", reason="optional cli dependencies aren't installed"`
`32`		`-)`
	`30`	`+cli = pytest.importorskip("zarr._cli.cli", reason="optional cli dependencies aren't installed")`
`33`	`31`
`34`	`32`	`runner = typer_testing.CliRunner()`
`35`	`33`