Skip to content

Commit 4ab33bf

Browse files
Experiment if we can remove the slow_wasm option now
1 parent 716dbcb commit 4ab33bf

3 files changed

Lines changed: 0 additions & 15 deletions

File tree

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,6 @@ markers = [
454454
"asyncio: mark test as asyncio test",
455455
"gpu: mark a test as requiring CuPy and GPU",
456456
"slow_hypothesis: slow hypothesis tests",
457-
"slow_wasm: slow tests in Pyodide/WASM",
458457
]
459458

460459
[tool.repo-review]

tests/conftest.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -283,30 +283,17 @@ def pytest_addoption(parser: Any) -> None:
283283
default=False,
284284
help="run slow hypothesis tests",
285285
)
286-
parser.addoption(
287-
"--run-slow-wasm",
288-
action="store_true",
289-
default=False,
290-
help="run slow tests only applicable to WASM",
291-
)
292286

293287

294288
def pytest_collection_modifyitems(config: Any, items: Any) -> None:
295289
if config.getoption("--run-slow-hypothesis"):
296290
return
297-
if config.getoption("--run-slow-wasm") and IS_WASM:
298-
return
299291

300292
skip_slow_hyp = pytest.mark.skip(reason="need --run-slow-hypothesis option to run")
301-
skip_slow_wasm = pytest.mark.skip(
302-
reason="need --run-slow-wasm option to run in WASM, or not running in WASM"
303-
)
304293

305294
for item in items:
306295
if "slow_hypothesis" in item.keywords:
307296
item.add_marker(skip_slow_hyp)
308-
if "slow_wasm" in item.keywords and IS_WASM:
309-
item.add_marker(skip_slow_wasm)
310297

311298

312299
settings.register_profile(

tests/test_properties.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,6 @@ async def test_vindex(data: st.DataObject) -> None:
247247
# note: async vindex setitem not yet implemented
248248

249249

250-
@pytest.mark.slow_wasm
251250
@given(store=stores, meta=array_metadata()) # type: ignore[misc]
252251
@pytest.mark.filterwarnings("ignore::zarr.core.dtype.common.UnstableSpecificationWarning")
253252
async def test_roundtrip_array_metadata_from_store(

0 commit comments

Comments
 (0)