implement default on store abc

Author: d-v-b

src/zarr/abc/store.py

@@ -8,6 +8,7 @@
 from typing import TYPE_CHECKING, Literal, Protocol, runtime_checkable
 
 from zarr.core.buffer import Buffer, BufferPrototype
+from zarr.core.buffer.core import default_buffer_prototype
 from zarr.core.sync import sync
 
 if TYPE_CHECKING:
@@ -184,12 +185,11 @@ def __eq__(self, value: object) -> bool:
         """Equality comparison."""
         ...
 
-    @abstractmethod
     def _get_default_buffer_class(self) -> type[Buffer]:
         """
-        Get the default buffer class for this store.
+        Get the default buffer class.
         """
-        ...
+        return default_buffer_prototype().buffer
 
     @abstractmethod
     async def get(

src/zarr/storage/_fsspec.py

@@ -16,7 +16,6 @@
     SuffixByteRequest,
 )
 from zarr.core.buffer import Buffer, BufferPrototype
-from zarr.core.buffer.core import default_buffer_prototype
 from zarr.errors import ZarrUserWarning
 from zarr.storage._common import _dereference_path
 
@@ -273,10 +272,6 @@ def __eq__(self, other: object) -> bool:
             and self.fs == other.fs
         )
 
-    def _get_default_buffer_class(self) -> type[Buffer]:
-        # docstring inherited
-        return default_buffer_prototype().buffer
-
     async def get(
         self,
         key: str,

src/zarr/storage/_local.py

@@ -19,7 +19,6 @@
     SuffixByteRequest,
 )
 from zarr.core.buffer import Buffer, BufferPrototype
-from zarr.core.buffer.core import default_buffer_prototype
 from zarr.core.common import AccessModeLiteral, concurrent_map
 
 if TYPE_CHECKING:
@@ -192,10 +191,6 @@ def __repr__(self) -> str:
     def __eq__(self, other: object) -> bool:
         return isinstance(other, type(self)) and self.root == other.root
 
-    def _get_default_buffer_class(self) -> type[Buffer]:
-        # docstring inherited
-        return default_buffer_prototype().buffer
-
     async def get(
         self,
         key: str,

src/zarr/storage/_memory.py

@@ -5,7 +5,6 @@
 
 from zarr.abc.store import BufferLike, ByteRequest, Store
 from zarr.core.buffer import Buffer, BufferPrototype, gpu
-from zarr.core.buffer.core import default_buffer_prototype
 from zarr.core.common import concurrent_map
 from zarr.storage._utils import _normalize_byte_range_index
 
@@ -58,10 +57,6 @@ def with_read_only(self, read_only: bool = False) -> MemoryStore:
             read_only=read_only,
         )
 
-    def _get_default_buffer_class(self) -> type[Buffer]:
-        # docstring inherited
-        return default_buffer_prototype().buffer
-
     async def clear(self) -> None:
         # docstring inherited
         self._store_dict.clear()

src/zarr/storage/_obstore.py

@@ -97,12 +97,6 @@ def __setstate__(self, state: dict[Any, Any]) -> None:
         state["store"] = pickle.loads(state["store"])
         self.__dict__.update(state)
 
-    def _get_default_buffer_class(self) -> type[Buffer]:
-        # docstring inherited
-        from zarr.core.buffer.core import default_buffer_prototype
-
-        return default_buffer_prototype().buffer
-
     async def get(
         self, key: str, prototype: BufferLike | None = None, byte_range: ByteRequest | None = None
     ) -> Buffer | None:

src/zarr/storage/_wrapper.py

@@ -83,10 +83,6 @@ def __str__(self) -> str:
     def __repr__(self) -> str:
         return f"WrapperStore({self._store.__class__.__name__}, '{self._store}')"
 
-    def _get_default_buffer_class(self) -> type[Buffer]:
-        # docstring inherited
-        return self._store._get_default_buffer_class()
-
     async def get(
         self, key: str, prototype: BufferLike | None = None, byte_range: ByteRequest | None = None
     ) -> Buffer | None:

src/zarr/storage/_zip.py

@@ -17,7 +17,6 @@
     SuffixByteRequest,
 )
 from zarr.core.buffer import Buffer, BufferPrototype
-from zarr.core.buffer.core import default_buffer_prototype
 
 if TYPE_CHECKING:
     from collections.abc import AsyncIterator, Iterable
@@ -145,10 +144,6 @@ def __repr__(self) -> str:
     def __eq__(self, other: object) -> bool:
         return isinstance(other, type(self)) and self.path == other.path
 
-    def _get_default_buffer_class(self) -> type[Buffer]:
-        # docstring inherited
-        return default_buffer_prototype().buffer
-
     def _get(
         self,
         key: str,