remove warning entirely

Author: slevang

src/zarr/codecs/numcodecs/_codecs.py

@@ -32,7 +32,6 @@
 from dataclasses import dataclass, replace
 from functools import cached_property
 from typing import TYPE_CHECKING, Any, Self
-from warnings import warn
 
 import numpy as np
 
@@ -41,7 +40,6 @@
 from zarr.core.buffer.cpu import as_numpy_array_wrapper
 from zarr.core.common import JSON, parse_named_configuration, product
 from zarr.dtype import UInt8, ZDType, parse_dtype
-from zarr.errors import ZarrUserWarning
 from zarr.registry import get_numcodec
 
 if TYPE_CHECKING:
@@ -113,12 +111,6 @@ def from_dict(cls, data: dict[str, JSON]) -> Self:
         return cls(**codec_config)
 
     def to_dict(self) -> dict[str, JSON]:
-        warn(
-            "Numcodecs codecs are not in the Zarr version 3 specification and "
-            "may not be supported by other zarr implementations.",
-            category=ZarrUserWarning,
-            stacklevel=2,
-        )
         codec_config = self.codec_config.copy()
         codec_config.pop("id", None)
         return {

tests/test_array.py

@@ -1853,24 +1853,21 @@ def test_roundtrip_numcodecs() -> None:
 
     # Create the array with the correct codecs
     root = zarr.group(store)
-    warn_msg = "Numcodecs codecs are not in the Zarr version 3 specification and may not be supported by other zarr implementations."
-    with pytest.warns(ZarrUserWarning, match=warn_msg):
-        root.create_array(
-            "test",
-            shape=(720, 1440),
-            chunks=(720, 1440),
-            dtype="float64",
-            compressors=compressors,  # type: ignore[arg-type]
-            filters=filters,  # type: ignore[arg-type]
-            fill_value=-9.99,
-            dimension_names=["lat", "lon"],
-        )
+    root.create_array(
+        "test",
+        shape=(720, 1440),
+        chunks=(720, 1440),
+        dtype="float64",
+        compressors=compressors,  # type: ignore[arg-type]
+        filters=filters,  # type: ignore[arg-type]
+        fill_value=-9.99,
+        dimension_names=["lat", "lon"],
+    )
 
     BYTES_CODEC = {"name": "bytes", "configuration": {"endian": "little"}}
     # Read in the array again and check compressor config
     root = zarr.open_group(store)
-    with pytest.warns(ZarrUserWarning, match=warn_msg):
-        metadata = root["test"].metadata.to_dict()
+    metadata = root["test"].metadata.to_dict()
     expected = (*filters, BYTES_CODEC, *compressors)
     assert metadata["codecs"] == expected
 

tests/test_cli/test_migrate_v3.py

@@ -32,8 +32,6 @@
 
 runner = typer_testing.CliRunner()
 
-NUMCODECS_USER_WARNING = "Numcodecs codecs are not in the Zarr version 3 specification and may not be supported by other zarr implementations."
-
 
 def test_migrate_array(local_store: LocalStore) -> None:
     shape = (10, 10)
@@ -316,7 +314,6 @@ def test_migrate_compressor(
     assert np.all(zarr_array[:] == 1)
 
 
-@pytest.mark.filterwarnings(f"ignore:{NUMCODECS_USER_WARNING}:UserWarning")
 def test_migrate_numcodecs_compressor(local_store: LocalStore) -> None:
     """Test migration of a numcodecs compressor without a zarr.codecs equivalent."""
 
@@ -360,7 +357,6 @@ def test_migrate_numcodecs_compressor(local_store: LocalStore) -> None:
     assert np.all(zarr_array[:] == 1)
 
 
-@pytest.mark.filterwarnings(f"ignore:{NUMCODECS_USER_WARNING}:UserWarning")
 def test_migrate_filter(local_store: LocalStore) -> None:
     filter_v2 = numcodecs.Delta(dtype="<u2", astype="<u2")
     filter_v3 = Delta(dtype="<u2", astype="<u2")

tests/test_codecs/test_numcodecs.py

@@ -2,7 +2,6 @@
 
 import contextlib
 import pickle
-import warnings
 from typing import TYPE_CHECKING, Any
 
 import numpy as np
@@ -18,7 +17,6 @@
 from zarr import config, create_array, open_array
 from zarr.abc.numcodec import _is_numcodec, _is_numcodec_cls
 from zarr.codecs import numcodecs as _numcodecs
-from zarr.errors import ZarrUserWarning
 from zarr.registry import get_codec_class, get_numcodec
 
 if TYPE_CHECKING:
@@ -77,8 +75,6 @@ def test_is_numcodec_cls() -> None:
     assert _is_numcodec_cls(GZip)
 
 
-EXPECTED_WARNING_STR = "Numcodecs codecs are not in the Zarr version 3.*"
-
 ALL_CODECS = tuple(
     filter(
         lambda v: issubclass(v, _numcodecs._NumcodecsCodec) and hasattr(v, "codec_name"),
@@ -116,15 +112,14 @@ def test_docstring(codec_class: type[_numcodecs._NumcodecsCodec]) -> None:
 def test_generic_compressor(codec_class: type[_numcodecs._NumcodecsBytesBytesCodec]) -> None:
     data = np.arange(0, 256, dtype="uint16").reshape((16, 16))
 
-    with pytest.warns(ZarrUserWarning, match=EXPECTED_WARNING_STR):
-        a = create_array(
-            {},
-            shape=data.shape,
-            chunks=(16, 16),
-            dtype=data.dtype,
-            fill_value=0,
-            compressors=[codec_class()],
-        )
+    a = create_array(
+        {},
+        shape=data.shape,
+        chunks=(16, 16),
+        dtype=data.dtype,
+        fill_value=0,
+        compressors=[codec_class()],
+    )
 
     a[:, :] = data.copy()
     np.testing.assert_array_equal(data, a[:, :])
@@ -151,17 +146,16 @@ def test_generic_filter(
 ) -> None:
     data = np.linspace(0, 10, 256, dtype="float32").reshape((16, 16))
 
-    with pytest.warns(ZarrUserWarning, match=EXPECTED_WARNING_STR):
-        a = create_array(
-            {},
-            shape=data.shape,
-            chunks=(16, 16),
-            dtype=data.dtype,
-            fill_value=0,
-            filters=[
-                codec_class(**codec_config),
-            ],
-        )
+    a = create_array(
+        {},
+        shape=data.shape,
+        chunks=(16, 16),
+        dtype=data.dtype,
+        fill_value=0,
+        filters=[
+            codec_class(**codec_config),
+        ],
+    )
 
     a[:, :] = data.copy()
     with codec_conf():
@@ -172,15 +166,14 @@ def test_generic_filter(
 def test_generic_filter_bitround() -> None:
     data = np.linspace(0, 1, 256, dtype="float32").reshape((16, 16))
 
-    with pytest.warns(ZarrUserWarning, match=EXPECTED_WARNING_STR):
-        a = create_array(
-            {},
-            shape=data.shape,
-            chunks=(16, 16),
-            dtype=data.dtype,
-            fill_value=0,
-            filters=[_numcodecs.BitRound(keepbits=3)],
-        )
+    a = create_array(
+        {},
+        shape=data.shape,
+        chunks=(16, 16),
+        dtype=data.dtype,
+        fill_value=0,
+        filters=[_numcodecs.BitRound(keepbits=3)],
+    )
 
     a[:, :] = data.copy()
     b = open_array(a.store, mode="r")
@@ -190,15 +183,14 @@ def test_generic_filter_bitround() -> None:
 def test_generic_filter_quantize() -> None:
     data = np.linspace(0, 10, 256, dtype="float32").reshape((16, 16))
 
-    with pytest.warns(ZarrUserWarning, match=EXPECTED_WARNING_STR):
-        a = create_array(
-            {},
-            shape=data.shape,
-            chunks=(16, 16),
-            dtype=data.dtype,
-            fill_value=0,
-            filters=[_numcodecs.Quantize(digits=3)],
-        )
+    a = create_array(
+        {},
+        shape=data.shape,
+        chunks=(16, 16),
+        dtype=data.dtype,
+        fill_value=0,
+        filters=[_numcodecs.Quantize(digits=3)],
+    )
 
     a[:, :] = data.copy()
     b = open_array(a.store, mode="r")
@@ -209,15 +201,14 @@ def test_generic_filter_packbits() -> None:
     data = np.zeros((16, 16), dtype="bool")
     data[0:4, :] = True
 
-    with pytest.warns(ZarrUserWarning, match=EXPECTED_WARNING_STR):
-        a = create_array(
-            {},
-            shape=data.shape,
-            chunks=(16, 16),
-            dtype=data.dtype,
-            fill_value=0,
-            filters=[_numcodecs.PackBits()],
-        )
+    a = create_array(
+        {},
+        shape=data.shape,
+        chunks=(16, 16),
+        dtype=data.dtype,
+        fill_value=0,
+        filters=[_numcodecs.PackBits()],
+    )
 
     a[:, :] = data.copy()
     b = open_array(a.store, mode="r")
@@ -253,15 +244,14 @@ def test_generic_checksum(codec_class: type[_numcodecs._NumcodecsBytesBytesCodec
 
     data = np.linspace(0, 10, 256, dtype="float32").reshape((16, 16))
 
-    with pytest.warns(ZarrUserWarning, match=EXPECTED_WARNING_STR):
-        a = create_array(
-            {},
-            shape=data.shape,
-            chunks=(16, 16),
-            dtype=data.dtype,
-            fill_value=0,
-            compressors=[codec_class()],
-        )
+    a = create_array(
+        {},
+        shape=data.shape,
+        chunks=(16, 16),
+        dtype=data.dtype,
+        fill_value=0,
+        compressors=[codec_class()],
+    )
 
     a[:, :] = data.copy()
     with codec_conf():
@@ -283,15 +273,14 @@ def test_generic_bytes_codec(codec_class: type[_numcodecs._NumcodecsArrayBytesCo
 
     data = np.arange(0, 256, dtype="float32").reshape((16, 16))
 
-    with pytest.warns(ZarrUserWarning, match=EXPECTED_WARNING_STR):
-        a = create_array(
-            {},
-            shape=data.shape,
-            chunks=(16, 16),
-            dtype=data.dtype,
-            fill_value=0,
-            serializer=codec_class(),
-        )
+    a = create_array(
+        {},
+        shape=data.shape,
+        chunks=(16, 16),
+        dtype=data.dtype,
+        fill_value=0,
+        serializer=codec_class(),
+    )
 
     a[:, :] = data.copy()
     np.testing.assert_array_equal(data, a[:, :])
@@ -300,17 +289,16 @@ def test_generic_bytes_codec(codec_class: type[_numcodecs._NumcodecsArrayBytesCo
 def test_delta_astype() -> None:
     data = np.linspace(0, 10, 256, dtype="i8").reshape((16, 16))
 
-    with pytest.warns(ZarrUserWarning, match=EXPECTED_WARNING_STR):
-        a = create_array(
-            {},
-            shape=data.shape,
-            chunks=(16, 16),
-            dtype=data.dtype,
-            fill_value=0,
-            filters=[
-                _numcodecs.Delta(dtype="i8", astype="i2"),
-            ],
-        )
+    a = create_array(
+        {},
+        shape=data.shape,
+        chunks=(16, 16),
+        dtype=data.dtype,
+        fill_value=0,
+        filters=[
+            _numcodecs.Delta(dtype="i8", astype="i2"),
+        ],
+    )
 
     a[:, :] = data.copy()
     with codec_conf():
@@ -325,36 +313,7 @@ def test_repr() -> None:
 
 def test_to_dict() -> None:
     codec = _numcodecs.LZ4(level=5)
-    with pytest.warns(ZarrUserWarning, match=EXPECTED_WARNING_STR):
-        assert codec.to_dict() == {"name": "numcodecs.lz4", "configuration": {"level": 5}}
-
-
-def test_warn_on_write_not_read() -> None:
-    data = np.arange(0, 256, dtype="uint16").reshape((16, 16))
-
-    with pytest.warns(ZarrUserWarning, match=EXPECTED_WARNING_STR):
-        a = create_array(
-            {},
-            shape=data.shape,
-            chunks=(16, 16),
-            dtype=data.dtype,
-            fill_value=0,
-            compressors=[_numcodecs.Zstd(level=1)],
-        )
-
-    a[:, :] = data.copy()
-    with codec_conf():
-        with warnings.catch_warnings(record=True) as caught:
-            warnings.simplefilter("always")
-            b = open_array(a.store, mode="r")
-
-    np.testing.assert_array_equal(data, b[:, :])
-    assert not [
-        warning
-        for warning in caught
-        if issubclass(warning.category, ZarrUserWarning)
-        and "Numcodecs codecs are not in the Zarr version 3 specification" in str(warning.message)
-    ]
+    assert codec.to_dict() == {"name": "numcodecs.lz4", "configuration": {"level": 5}}
 
 
 @pytest.mark.parametrize(