Skip to content

Commit c7ea02b

Browse files
author
Cipher
committed
style: fix ruff formatting and TRY300 in _check_scalar
1 parent 5cc034d commit c7ea02b

2 files changed

Lines changed: 14 additions & 4 deletions

File tree

src/zarr/core/dtype/npy/float.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,9 +207,10 @@ def _check_scalar(self, data: object) -> TypeGuard[FloatLike]:
207207
# raises TypeError rather than a confusing ValueError.
208208
try:
209209
self.to_native_dtype().type(data)
210-
return True
211210
except (ValueError, OverflowError):
212211
return False
212+
else:
213+
return True
213214
return isinstance(data, FloatLike)
214215

215216
def _cast_scalar_unchecked(self, data: FloatLike) -> TFloatScalar_co:

tests/test_dtype/test_npy/test_float.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,10 @@ class TestFloat16(_BaseTestFloat):
6565
(Float16(), -1.0, np.float16(-1.0)),
6666
(Float16(), "NaN", np.float16("NaN")),
6767
)
68-
invalid_scalar_params = ((Float16(), {"set!"}), (Float16(), "not_a_float"),)
68+
invalid_scalar_params = (
69+
(Float16(), {"set!"}),
70+
(Float16(), "not_a_float"),
71+
)
6972
hex_string_params = (("0x7fc0", np.nan), ("0x7fc1", np.nan), ("0x3c00", 1.0))
7073
item_size_params = (Float16(),)
7174

@@ -113,7 +116,10 @@ class TestFloat32(_BaseTestFloat):
113116
(Float32(), -1.0, np.float32(-1.0)),
114117
(Float32(), "NaN", np.float32("NaN")),
115118
)
116-
invalid_scalar_params = ((Float32(), {"set!"}), (Float32(), "not_a_float"),)
119+
invalid_scalar_params = (
120+
(Float32(), {"set!"}),
121+
(Float32(), "not_a_float"),
122+
)
117123
hex_string_params = (("0x7fc00000", np.nan), ("0x7fc00001", np.nan), ("0x3f800000", 1.0))
118124
item_size_params = (Float32(),)
119125

@@ -160,7 +166,10 @@ class TestFloat64(_BaseTestFloat):
160166
(Float64(), -1.0, np.float64(-1.0)),
161167
(Float64(), "NaN", np.float64("NaN")),
162168
)
163-
invalid_scalar_params = ((Float64(), {"set!"}), (Float64(), "not_a_float"),)
169+
invalid_scalar_params = (
170+
(Float64(), {"set!"}),
171+
(Float64(), "not_a_float"),
172+
)
164173
hex_string_params = (
165174
("0x7ff8000000000000", np.nan),
166175
("0x7ff8000000000001", np.nan),

0 commit comments

Comments
 (0)