Skip to content

Commit ce8caca

Browse files
authored
Merge branch 'main' into poc/unified-chunk-grid
2 parents dbd2cf8 + 00c1463 commit ce8caca

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

.github/workflows/releases.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
name: Wheels
22

33
on:
4+
release:
5+
types:
6+
- published
47
push:
58
branches: [main]
69
pull_request:
@@ -64,7 +67,7 @@ jobs:
6467
name: Upload to PyPI
6568
needs: [build_artifacts, test_dist_pypi]
6669
runs-on: ubuntu-latest
67-
if: github.event_name == 'push' && startsWith(github.event.ref, 'refs/tags/v')
70+
if: github.event_name == 'release'
6871
environment:
6972
name: releases
7073
url: https://pypi.org/p/zarr

docs/release-notes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,7 @@
461461
- Test that a `ValueError` is raised for invalid byte range syntax in `StoreTests`. ([#2693](https://github.com/zarr-developers/zarr-python/issues/2693))
462462
- Separate instantiating and opening a store in `StoreTests`. ([#2693](https://github.com/zarr-developers/zarr-python/issues/2693))
463463
- Add a test for using Stores as a context managers in `StoreTests`. ([#2693](https://github.com/zarr-developers/zarr-python/issues/2693))
464-
- Implemented `LogingStore.open()`. ([#2693](https://github.com/zarr-developers/zarr-python/issues/2693))
464+
- Implemented `LoggingStore.open()`. ([#2693](https://github.com/zarr-developers/zarr-python/issues/2693))
465465
- `LoggingStore` is now a generic class. ([#2693](https://github.com/zarr-developers/zarr-python/issues/2693))
466466
- Change StoreTest's `test_store_repr`, `test_store_supports_writes`,
467467
`test_store_supports_partial_writes`, and `test_store_supports_listing`

tests/test_array.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -209,19 +209,19 @@ def test_array_name_properties_with_group(
209209

210210
@pytest.mark.filterwarnings("ignore::zarr.core.dtype.common.UnstableSpecificationWarning")
211211
@pytest.mark.parametrize("store", ["memory"], indirect=True)
212-
@pytest.mark.parametrize("specifiy_fill_value", [True, False])
212+
@pytest.mark.parametrize("specify_fill_value", [True, False])
213213
@pytest.mark.parametrize(
214214
"zdtype", zdtype_examples, ids=tuple(str(type(v)) for v in zdtype_examples)
215215
)
216216
def test_array_fill_value_default(
217-
store: MemoryStore, specifiy_fill_value: bool, zdtype: ZDType[Any, Any]
217+
store: MemoryStore, specify_fill_value: bool, zdtype: ZDType[Any, Any]
218218
) -> None:
219219
"""
220220
Test that creating an array with the fill_value parameter set to None, or unspecified,
221221
results in the expected fill_value attribute of the array, i.e. the default value of the dtype
222222
"""
223223
shape = (10,)
224-
if specifiy_fill_value:
224+
if specify_fill_value:
225225
arr = zarr.create_array(
226226
store=store,
227227
shape=shape,

0 commit comments

Comments
 (0)