Add full copy of zarr-python v2.18.7 under src/zarr/v2#3075
Open
jni wants to merge 2 commits intozarr-developers:mainfrom
Open
Add full copy of zarr-python v2.18.7 under src/zarr/v2#3075jni wants to merge 2 commits intozarr-developers:mainfrom
jni wants to merge 2 commits intozarr-developers:mainfrom
Conversation
Contributor
Author
|
Hmm looks like I have a lot of test fixing in my future. 😂 |
Member
|
Thanks for doing this @jni - I think would personally very much appreciate this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposes to include a complete copy of zarr v2.18.7 under the zarr.v2
namespace. The goal is for libraries using the v2 API to be able to migrate
gradually, and not have to be environment-incompatible with libraries that have
fully migrated to v3. Such libraries could then do:
It would also buy us more time to improve the migration guide.
For more discussion, see this Zulip thread.
Currently, I have not imported it in
zarr.__init__.py, so one would have toexplicitly import it to discover it. I think that's probably the right thing.
TODO:
Add unit tests and/or doctests in docstringsAdd docstrings and API docs for any new/modified user-facing classes and functionsdocs/user-guide/*.rstchanges/