Enforce Pylint rules#3131
Open
DimitriPapadopoulos wants to merge 11 commits intozarr-developers:mainfrom
Open
Conversation
github-actions
bot
added
the
needs release notes
DimitriPapadopoulos
force-pushed
the
sourcery
branch
from
17048f6 to
bc765d8
Compare
Contributor
|
I'm 👍 for spelling fixes, and 👎 for refactoring without a linter doing it automatically for us (because it just creates PR review noise for not much technical debt reduction). Could you open a PR to repalce this that just includes the spelling fixes? |
Contributor
Author
|
I think Sourcery applies linter rules, but rules that might not be part of ruff (yet). More importantly, I think Sourcery is a good addition - AI assistance for PR review. But I understand you don't agree with it. Some of the Sourcery suggestions - n_ellipsis = sum(1 for i in selection if i is Ellipsis)
+ n_ellipsis = selection.count(Ellipsis)How about keeping the couple changes that really make sense? |
DimitriPapadopoulos
force-pushed
the
sourcery
branch
12 times, most recently
from
bec6be5 to
7270dd1
Compare
DimitriPapadopoulos
force-pushed
the
sourcery
branch
3 times, most recently
from
f55e79a to
5a1df20
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3131 +/- ##
=======================================
Coverage 61.74% 61.74%
=======================================
Files 85 85
Lines 10179 10175 -4
=======================================
- Hits 6285 6283 -2
+ Misses 3894 3892 -2
🚀 New features to boost your workflow:
|
DimitriPapadopoulos
force-pushed
the
sourcery
branch
2 times, most recently
from
58a885b to
ae772b5
Compare
DimitriPapadopoulos
force-pushed
the
sourcery
branch
from
ae772b5 to
03d87ce
Compare
DimitriPapadopoulos
force-pushed
the
sourcery
branch
2 times, most recently
from
679e33e to
6c9c486
Compare
DimitriPapadopoulos
changed the title
DimitriPapadopoulos
force-pushed
the
sourcery
branch
from
6c9c486 to
3161442
Compare
DimitriPapadopoulos
force-pushed
the
sourcery
branch
from
3161442 to
49fc9a3
Compare
DimitriPapadopoulos
force-pushed
the
sourcery
branch
2 times, most recently
from
28ba0c1 to
40ef12e
Compare
Contributor
Author
|
I have added Pylint to CI. Adding it to pre-commit is discouraged because it is slow and incompatible with pre-commit parallelisation: |
DimitriPapadopoulos
force-pushed
the
sourcery
branch
3 times, most recently
from
ce0a3ac to
77f5237
Compare
Disable rules that: - we don't want to fix, - have been implemenetd in ruff, - could be enabled later and are currently followed by `FIXME`.
FURB140 Use `itertools.starmap` instead of the generator
Unnecessary ellipsis constant
Attribute '_is_open' defined outside __init__
Useless parent or super() delegation in method '__init__'
Reimport 'ArrayV3Metadata'
Unnecessary parens after 'not' keyword
Do not raise StopIteration in generator, use return statement instead
DimitriPapadopoulos
force-pushed
the
sourcery
branch
from
77f5237 to
adbf3a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also a couple Pylint rules that may not yet be implemented in ruff.Edit: Run Pylint in addition to ruff, because not all Pylint rules have been or can be implemented in ruff.
TODO:
docs/user-guide/*.rstchanges/