obstore implementations for .getsize and .getsize_prefix#3227
Merged
d-v-b merged 5 commits intozarr-developers:mainfrom Jul 17, 2025
Merged
obstore implementations for .getsize and .getsize_prefix#3227d-v-b merged 5 commits intozarr-developers:mainfrom
d-v-b merged 5 commits intozarr-developers:mainfrom
Conversation
464d041 to
11cfc45
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3227 +/- ##
==========================================
- Coverage 59.59% 59.57% -0.02%
==========================================
Files 78 78
Lines 8696 8701 +5
==========================================
+ Hits 5182 5184 +2
- Misses 3514 3517 +3
🚀 New features to boost your workflow:
|
Contributor
|
Thanks for the PR. I think if you can merge |
TomAugspurger
approved these changes
Jul 16, 2025
38aa2eb to
8eaeaf0
Compare
Contributor
Author
|
@TomAugspurger thanks for the review! these failures seem unrelated, what else could I do here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3218
ListStream[list[ObjectMeta]]withListStream[Sequence[ObjectMeta]]- this appears problematic with obstore 0.7.0 and mypy.TODO:
docs/user-guide/*.rstchanges/